From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>, linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl,
mchehab@kernel.org, yangyingliang@huawei.com
Subject: Re: [PATCH] media: imx: imx7-media-csi: fix missing clk_disable_unprepare() in imx7_csi_init()
Date: Wed, 04 Jan 2023 16:25:05 +0000 [thread overview]
Message-ID: <m3bkne468u.fsf@gmail.com> (raw)
In-Reply-To: <20230104093921.2570431-1-yangyingliang@huawei.com>
Hey Yingliang,
Yang Yingliang <yangyingliang@huawei.com> writes:
> Add missing clk_disable_unprepare(), if imx7_csi_dma_setup() fails
> in imx7_csi_init().
>
> Fixes: ff43ca911978 ("media: imx: imx7-media-csi: Move CSI configuration before source start")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
LGTM, Many thanks.
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Cheers,
Rui
> ---
> drivers/media/platform/nxp/imx7-media-csi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c
> index 886374d3a6ff..1ef92c8c0098 100644
> --- a/drivers/media/platform/nxp/imx7-media-csi.c
> +++ b/drivers/media/platform/nxp/imx7-media-csi.c
> @@ -638,8 +638,10 @@ static int imx7_csi_init(struct imx7_csi *csi)
> imx7_csi_configure(csi);
>
> ret = imx7_csi_dma_setup(csi);
> - if (ret < 0)
> + if (ret < 0) {
> + clk_disable_unprepare(csi->mclk);
> return ret;
> + }
>
> return 0;
> }
> --
> 2.25.1
prev parent reply other threads:[~2023-01-04 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:39 [PATCH] media: imx: imx7-media-csi: fix missing clk_disable_unprepare() in imx7_csi_init() Yang Yingliang
2023-01-04 12:26 ` Laurent Pinchart
2023-01-04 16:25 ` Rui Miguel Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bkne468u.fsf@gmail.com \
--to=rmfrfs@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).