linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Steve Longerbeam <slongerbeam@gmail.com>,
	Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v4 0/8] Switch to sync registration for IPU subdevs
Date: Mon, 06 May 2019 22:16:21 +0100	[thread overview]
Message-ID: <m3ftpr5lne.fsf@gmail.com> (raw)
In-Reply-To: <20190503224326.21039-1-slongerbeam@gmail.com>

Hi Steve,
On Fri 03 May 2019 at 23:43, Steve Longerbeam wrote:
> Switch to sync registration for the IPU internal sub-devices, re-organize
> modules, and a few other miscellaneous cleanups.

Thanks for the series and the fixes. Now everything works as
before. So, for the all series and related to imx7:

Tested-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

My only concern is that Hans already pull requested to v5.2 [0] my
previous patch that your series do not apply on top of.

So, @Hans will you push this series to v5.2 and add a revert
of [1]? or this will go only to v5.3?

---
Cheers,
	Rui


[0]: https://lore.kernel.org/linux-media/d5b4a68d-520e-0e93-d44e-07974058d690@xs4all.nl/
[1]: https://lore.kernel.org/linux-media/20190412164400.1270-1-rui.silva@linaro.org/


>
> History:
> v4:
> - Add **cc arg to __capture_try_fmt_vid_cap() to validate colorspace,
>   instead of calling ipu_pixelformat_to_colorspace().
> - Add error message if capture format validation failed.
> v3:
> - A couple patches did not compile/link. All patches now build so the
>   series is fully bisectable. No functional changes.
> v2:
> - Added a patch that improves the pipeline upstream/downstream search
>   functions, which no longer require the media device.
> - Add a patch to remove getting media device from v4l2_dev driver data.
>
>
> Steve Longerbeam (8):
>   media: staging/imx: Switch to sync registration for IPU subdevs
>   media: staging/imx: Pass device to alloc/free_dma_buf
>   media: staging/imx: Move add_video_device into capture_device_register
>   Revert "media: imx: Set capture compose rectangle in
>     capture_device_set_format"
>   media: staging/imx: Remove capture_device_set_format
>   media: staging/imx: Re-organize modules
>   media: staging/imx: Improve pipeline searching
>   media: staging/imx: Don't set driver data for v4l2_dev
>
>  drivers/staging/media/imx/Makefile            |  18 +-
>  drivers/staging/media/imx/imx-ic-common.c     |  68 +--
>  drivers/staging/media/imx/imx-ic-prp.c        |  36 +-
>  drivers/staging/media/imx/imx-ic-prpencvf.c   |  88 ++--
>  drivers/staging/media/imx/imx-ic.h            |   6 +-
>  drivers/staging/media/imx/imx-media-capture.c |  90 ++--
>  drivers/staging/media/imx/imx-media-csi.c     |  45 +-
>  .../staging/media/imx/imx-media-dev-common.c  | 346 +++++++++++++-
>  drivers/staging/media/imx/imx-media-dev.c     | 449 +-----------------
>  drivers/staging/media/imx/imx-media-fim.c     |   9 -
>  .../staging/media/imx/imx-media-internal-sd.c | 357 ++++++--------
>  drivers/staging/media/imx/imx-media-of.c      |  41 +-
>  drivers/staging/media/imx/imx-media-utils.c   | 170 +++----
>  drivers/staging/media/imx/imx-media-vdic.c    |  84 +---
>  drivers/staging/media/imx/imx-media.h         | 113 +++--
>  drivers/staging/media/imx/imx7-media-csi.c    |  43 +-
>  16 files changed, 857 insertions(+), 1106 deletions(-)


  parent reply	other threads:[~2019-05-06 21:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 22:43 [PATCH v4 0/8] Switch to sync registration for IPU subdevs Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 1/8] media: staging/imx: " Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 2/8] media: staging/imx: Pass device to alloc/free_dma_buf Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 3/8] media: staging/imx: Move add_video_device into capture_device_register Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 4/8] Revert "media: imx: Set capture compose rectangle in capture_device_set_format" Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 5/8] media: staging/imx: Remove capture_device_set_format Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 6/8] media: staging/imx: Re-organize modules Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 7/8] media: staging/imx: Improve pipeline searching Steve Longerbeam
2019-05-03 22:43 ` [PATCH v4 8/8] media: staging/imx: Don't set driver data for v4l2_dev Steve Longerbeam
2019-05-06 21:16 ` Rui Miguel Silva [this message]
2019-05-10 11:18   ` [PATCH v4 0/8] Switch to sync registration for IPU subdevs Hans Verkuil
2019-05-10 13:45     ` Rui Miguel Silva
2019-05-10 16:43     ` Steve Longerbeam
2019-05-10 16:44       ` Steve Longerbeam
2019-05-10 21:21         ` Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ftpr5lne.fsf@gmail.com \
    --to=rmfrfs@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).