From: khalasa@piap.pl (Krzysztof Hałasa)
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
andrey_utkin@fastmail.com
Subject: Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)
Date: Wed, 21 Sep 2016 15:16:57 +0200 [thread overview]
Message-ID: <m3k2e5wfxy.fsf@t19.piap.pl> (raw)
In-Reply-To: <9cbb2079-f705-5312-d295-34bc3c8dadb9@xs4all.nl> (Hans Verkuil's message of "Thu, 15 Sep 2016 15:15:53 +0200")
Hans Verkuil <hverkuil@xs4all.nl> writes:
> That was probably the reason for the pci_read_config_word in the reg_write
> code. Try putting that back (and just that).
Yes. I guess a single pci_read_config_word() would suffice.
Though it would obviously be much better to identify the place in the
driver which needs to have the write buffers flushed, and add a read()
just there.
The interrupt handler maybe (e.g. just before the return IRQ_HANDLED)?
OTOH this may be some sort of timing problem, I mean the faster code may
put too much stress on the SOLO chip.
Doesn't happen here so I can't test the cure.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-09-21 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:04 solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin
2016-09-15 13:15 ` Hans Verkuil
2016-09-15 13:19 ` Andrey Utkin
2016-09-15 13:25 ` Hans Verkuil
2016-09-15 13:58 ` One Thousand Gnomes
2016-09-21 13:16 ` Krzysztof Hałasa [this message]
2016-09-21 13:45 ` Andrey Utkin
2016-09-22 8:51 ` Krzysztof Hałasa
2016-09-22 15:23 ` Andrey Utkin
2016-09-26 5:38 ` Krzysztof Hałasa
2016-09-26 9:18 ` Andrey Utkin
2016-09-27 5:27 ` Krzysztof Hałasa
2016-09-27 7:40 ` Andrey Utkin
2016-09-27 11:33 ` Krzysztof Hałasa
2016-09-27 14:22 ` Andrey Utkin
2016-09-28 5:21 ` Krzysztof Hałasa
2016-10-24 19:32 ` Mauro Carvalho Chehab
2016-10-24 20:56 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k2e5wfxy.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=andrey_utkin@fastmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael@iodev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox