From: khalasa@piap.pl (Krzysztof Hałasa)
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>
Subject: Re: i.MX6 IPU CSI analog video input on Ventana
Date: Fri, 01 Jun 2018 12:02:31 +0200 [thread overview]
Message-ID: <m3sh66omdk.fsf@t19.piap.pl> (raw)
In-Reply-To: <6923fcd4-317e-d6a6-7975-47a8c712f8f9@gmail.com> (Steve Longerbeam's message of "Wed, 30 May 2018 13:56:34 -0700")
Steve Longerbeam <slongerbeam@gmail.com> writes:
> I tend to agree, I've found conflicting info out there regarding
> PAL vs. NTSC field order. And I've never liked having to guess
> at input analog standard based on input # lines. I will go ahead
> and remove the field order override code.
I've merged your current fix-csi-interlaced.2 branch (2018-06-01
00:06:45 UTC 22ad9f30454b6e46979edf6f8122243591910a3e) along with
"media: adv7180: fix field type" commit and NTSC camera:
media-ctl -V "'adv7180 2-0020':0 [fmt:UYVY2X8/720x480 field:alternate]"
media-ctl -V "'ipu2_csi1_mux':2 [fmt:UYVY2X8/720x480]"
media-ctl -V "'ipu2_csi1':2 [fmt:AYUV32/720x480 field:interlaced/-bt/-tb]"
correctly sets:
"adv7180 2-0020":0 [fmt:UYVY2X8/720x480 field:alternate]
"ipu2_csi1_mux":1 [fmt:UYVY2X8/720x480 field:alternate]
"ipu2_csi1_mux":2 [fmt:UYVY2X8/720x480 field:alternate]
"ipu2_csi1":0 [fmt:UYVY2X8/720x480 field:alternate]
"ipu2_csi1":2 [fmt:AYUV32/720x480 field:interlaced/-bt/-tb]
but all 3 cases seem to produce top-first interlaced frames.
The CCIR_CODE_* register dump shows no differences:
2a38014: 010D07DF 00040596 00FF0000
...it's because the code in drivers/gpu/ipu-v3/ipu-csi.c still sets the
registers depending on the height of the image. Hovewer, I'm using 480
lines here, so it should be B-T instead. My guess is the CSI is skipping
the first incomplete line (half-line - the first visible line has full
length) and BT becomes TB.
It seems writing to the CCIR_CODE_[12] registers does the trick, though
(the captured frames aren't correct and have the lines swapped in pairs
because t/b field pointers aren't correctly set).
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2018-06-01 10:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 8:19 i.MX6 IPU CSI analog video input on Ventana Krzysztof Hałasa
2018-05-10 16:32 ` Steve Longerbeam
2018-05-11 5:37 ` Krzysztof Hałasa
2018-05-11 17:35 ` Steve Longerbeam
2018-05-18 17:28 ` Krzysztof Hałasa
2018-05-18 17:56 ` Tim Harvey
2018-05-21 5:51 ` Krzysztof Hałasa
2018-05-21 8:09 ` Krzysztof Hałasa
2018-05-21 15:55 ` Tim Harvey
2018-05-21 21:25 ` Steve Longerbeam
2018-05-22 10:48 ` Krzysztof Hałasa
2018-05-24 15:56 ` Krzysztof Hałasa
2018-05-24 18:12 ` Steve Longerbeam
2018-05-24 20:48 ` Steve Longerbeam
2018-05-24 21:33 ` Steve Longerbeam
2018-05-25 6:34 ` Philipp Zabel
2018-05-25 5:21 ` Krzysztof Hałasa
2018-05-25 6:32 ` Philipp Zabel
2018-05-25 7:18 ` Krzysztof Hałasa
2018-05-25 23:39 ` Steve Longerbeam
2018-05-29 7:26 ` Krzysztof Hałasa
2018-05-29 14:00 ` Steve Longerbeam
2018-05-30 8:53 ` Krzysztof Hałasa
2018-05-30 17:57 ` Steve Longerbeam
2018-05-30 18:46 ` Krzysztof Hałasa
2018-05-30 20:56 ` Steve Longerbeam
2018-05-31 6:29 ` Philipp Zabel
2018-06-01 5:23 ` Krzysztof Hałasa
2018-06-02 17:33 ` Steve Longerbeam
2018-06-04 8:38 ` Philipp Zabel
2018-06-01 10:02 ` Krzysztof Hałasa [this message]
2018-06-01 13:13 ` Philipp Zabel
2018-06-02 17:45 ` Steve Longerbeam
2018-06-04 7:33 ` Krzysztof Hałasa
2018-06-04 8:47 ` Philipp Zabel
2018-06-04 8:58 ` Krzysztof Hałasa
2018-10-17 20:38 ` Tim Harvey
[not found] ` <57dfdc0b-5f04-e10a-2ffd-c7ba561fe7ce@gmail.com>
2018-10-17 23:05 ` Tim Harvey
2018-10-17 23:37 ` Steve Longerbeam
2018-10-18 17:56 ` Tim Harvey
2018-10-19 20:06 ` Steve Longerbeam
2018-10-19 9:45 ` Philipp Zabel
2018-06-04 7:06 ` Krzysztof Hałasa
2018-05-25 23:21 ` Steve Longerbeam
2018-06-01 13:52 ` Philipp Zabel
2018-05-25 7:07 ` Krzysztof Hałasa
2018-05-22 9:41 ` Franz Melchior
2018-05-11 6:11 ` Franz Melchior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sh66omdk.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox