From: khalasa@piap.pl (Krzysztof Hałasa)
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: linux-media <linux-media@vger.kernel.org>,
zhaoxuegang <zhaoxuegang@suntec.net>
Subject: Re: [PATCH] TW686x: Fix OOPS on buffer alloc failure
Date: Fri, 12 May 2017 06:39:47 +0200 [thread overview]
Message-ID: <m3zieiheng.fsf@t19.piap.pl> (raw)
In-Reply-To: <CAAEAJfAo8-efB-ZopydXFdRZDKsTKcSzx1vkaJwcpDQQ1Eiivw@mail.gmail.com> (Ezequiel Garcia's message of "Thu, 11 May 2017 13:04:42 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> How about this one (untested) ?
>
> diff --git a/drivers/media/pci/tw686x/tw686x-video.c
> b/drivers/media/pci/tw686x/tw686x-video.c
> index c3fafa97b2d0..77b8d2dbd995 100644
> --- a/drivers/media/pci/tw686x/tw686x-video.c
> +++ b/drivers/media/pci/tw686x/tw686x-video.c
> @@ -86,6 +86,9 @@ static void tw686x_memcpy_dma_free(struct
> tw686x_video_channel *vc,
> struct pci_dev *pci_dev;
> unsigned long flags;
>
> + /* Make sure this channel is initialized */
> + if (!dev)
> + return;
Whatever you wish. Just make sure it doesn't bomb out by default, when
one happens to have such a card in his or her machine.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2017-05-12 4:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <590ADAB1.1040501@suntec.net>
2017-05-10 9:48 ` [PCIE device driver: tw686x] I have some problems with tw686x and I need help Krzysztof Hałasa
2017-05-10 9:51 ` [PATCH] TW686x: Fix OOPS on buffer alloc failure Krzysztof Hałasa
2017-05-10 16:18 ` Ezequiel Garcia
2017-05-11 7:41 ` Krzysztof Hałasa
2017-05-11 16:04 ` Ezequiel Garcia
2017-05-12 4:39 ` Krzysztof Hałasa [this message]
[not found] ` <b088a7cd-7585-5235-224d-a90ea9042c24@xs4all.nl>
2017-06-23 8:18 ` Krzysztof Hałasa
2017-06-23 14:52 ` Ezequiel Garcia
[not found] ` <5913C1BB.8000103@suntec.net>
2017-05-11 8:02 ` Krzysztof Hałasa
2018-06-28 21:45 [PATCH] tw686x: Fix oops " Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zieiheng.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-media@vger.kernel.org \
--cc=zhaoxuegang@suntec.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox