* [PATCH 1 of 2] cx88: Add module parameter to control chroma AGC
2008-03-08 18:05 [PATCH 0 of 2] cx88: Enable additional cx2388x features Frej Drejhammar
@ 2008-03-08 18:05 ` Frej Drejhammar
2008-03-08 18:05 ` [PATCH 2 of 2] cx88: Add module parameter to control color killer Frej Drejhammar
2008-03-09 18:32 ` [PATCH 0 of 2] cx88: Enable additional cx2388x features Trent Piepho
2 siblings, 0 replies; 6+ messages in thread
From: Frej Drejhammar @ 2008-03-08 18:05 UTC (permalink / raw)
To: video4linux-list
1 file changed, 5 insertions(+), 1 deletion(-)
linux/drivers/media/video/cx88/cx88-core.c | 6 +++++-
# HG changeset patch
# User "Frej Drejhammar <frej.drejhammar@gmail.com>"
# Date 1204989936 -3600
# Node ID d628824bec6646cc474d13fd47ff03034119d83a
# Parent ad0b1f882ad988ae2f80ebbbe914092a4a963f04
cx88: Add module parameter to control chroma AGC
From: "Frej Drejhammar <frej.drejhammar@gmail.com>"
The cx2388x family has support for chroma AGC but no way for a casual
user to enable it. This patch adds the module parameter chroma_agc
which if non-zero enables the AGC. By default chroma AGC is disabled,
as in previous versions of the driver.
Signed-off-by: "Frej Drejhammar <frej.drejhammar@gmail.com>"
diff -r ad0b1f882ad9 -r d628824bec66 linux/drivers/media/video/cx88/cx88-core.c
--- a/linux/drivers/media/video/cx88/cx88-core.c Wed Mar 05 20:24:43 2008 +0000
+++ b/linux/drivers/media/video/cx88/cx88-core.c Sat Mar 08 16:25:36 2008 +0100
@@ -61,6 +61,10 @@ static unsigned int nocomb;
static unsigned int nocomb;
module_param(nocomb,int,0644);
MODULE_PARM_DESC(nocomb,"disable comb filter");
+
+static unsigned int chroma_agc;
+module_param(chroma_agc, int, 0444);
+MODULE_PARM_DESC(chroma_agc, "enable chroma agc");
#define dprintk(level,fmt, arg...) if (core_debug >= level) \
printk(KERN_DEBUG "%s: " fmt, core->name , ## arg)
@@ -628,7 +632,7 @@ int cx88_reset(struct cx88_core *core)
cx_write(MO_INPUT_FORMAT, ((1 << 13) | // agc enable
(1 << 12) | // agc gain
(1 << 11) | // adaptibe agc
- (0 << 10) | // chroma agc
+ chroma_agc ? (1 << 10) : 0 |
(0 << 9) | // ckillen
(7)));
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2 of 2] cx88: Add module parameter to control color killer
2008-03-08 18:05 [PATCH 0 of 2] cx88: Enable additional cx2388x features Frej Drejhammar
2008-03-08 18:05 ` [PATCH 1 of 2] cx88: Add module parameter to control chroma AGC Frej Drejhammar
@ 2008-03-08 18:05 ` Frej Drejhammar
2008-03-09 18:32 ` [PATCH 0 of 2] cx88: Enable additional cx2388x features Trent Piepho
2 siblings, 0 replies; 6+ messages in thread
From: Frej Drejhammar @ 2008-03-08 18:05 UTC (permalink / raw)
To: video4linux-list
1 file changed, 5 insertions(+), 1 deletion(-)
linux/drivers/media/video/cx88/cx88-core.c | 6 +++++-
# HG changeset patch
# User "Frej Drejhammar <frej.drejhammar@gmail.com>"
# Date 1204990024 -3600
# Node ID 37b97e1d079850e00df8bd8cb540ae7978341489
# Parent d628824bec6646cc474d13fd47ff03034119d83a
cx88: Add module parameter to control color killer
From: "Frej Drejhammar <frej.drejhammar@gmail.com>"
The cx2388x family has support for a color killer but no way for a
casual user to enable it. This patch adds the module parameter
color_killer which if non-zero enables the killer. By default the
color killer is disabled, as in previous versions of the driver.
Signed-off-by: "Frej Drejhammar <frej.drejhammar@gmail.com>"
diff -r d628824bec66 -r 37b97e1d0798 linux/drivers/media/video/cx88/cx88-core.c
--- a/linux/drivers/media/video/cx88/cx88-core.c Sat Mar 08 16:25:36 2008 +0100
+++ b/linux/drivers/media/video/cx88/cx88-core.c Sat Mar 08 16:27:04 2008 +0100
@@ -65,6 +65,10 @@ static unsigned int chroma_agc;
static unsigned int chroma_agc;
module_param(chroma_agc, int, 0444);
MODULE_PARM_DESC(chroma_agc, "enable chroma agc");
+
+static unsigned int color_killer;
+module_param(color_killer, int, 0444);
+MODULE_PARM_DESC(color_killer, "enable color killer");
#define dprintk(level,fmt, arg...) if (core_debug >= level) \
printk(KERN_DEBUG "%s: " fmt, core->name , ## arg)
@@ -633,7 +637,7 @@ int cx88_reset(struct cx88_core *core)
(1 << 12) | // agc gain
(1 << 11) | // adaptibe agc
chroma_agc ? (1 << 10) : 0 |
- (0 << 9) | // ckillen
+ color_killer ? (1 << 9) : 0 |
(7)));
/* setup image format */
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features
2008-03-08 18:05 [PATCH 0 of 2] cx88: Enable additional cx2388x features Frej Drejhammar
2008-03-08 18:05 ` [PATCH 1 of 2] cx88: Add module parameter to control chroma AGC Frej Drejhammar
2008-03-08 18:05 ` [PATCH 2 of 2] cx88: Add module parameter to control color killer Frej Drejhammar
@ 2008-03-09 18:32 ` Trent Piepho
2008-03-09 19:19 ` Frej Drejhammar
2008-03-10 1:01 ` hermann pitton
2 siblings, 2 replies; 6+ messages in thread
From: Trent Piepho @ 2008-03-09 18:32 UTC (permalink / raw)
To: Frej Drejhammar; +Cc: Linux and Kernel Video
On Sat, 8 Mar 2008, Frej Drejhammar wrote:
> The cx2388x family of broadcast decoders all have features not enabled
> by the standard cx88 driver. This patch series adds module parameters
> allowing the chroma AGC and the color killer to be enabled. By default
> both features are disabled as in previous versions of the driver.
>
> The Chroma AGC and the color killer is sometimes needed when using
> signal sources of less than optimal quality.
This really should be done with controls, not more module parameters.
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features
2008-03-09 18:32 ` [PATCH 0 of 2] cx88: Enable additional cx2388x features Trent Piepho
@ 2008-03-09 19:19 ` Frej Drejhammar
2008-03-10 1:01 ` hermann pitton
1 sibling, 0 replies; 6+ messages in thread
From: Frej Drejhammar @ 2008-03-09 19:19 UTC (permalink / raw)
To: Trent Piepho; +Cc: Linux and Kernel Video
> This really should be done with controls, not more module parameters.
I was not aware that you could add custom controls, your comment
prompted me to find V4L2_CID_PRIVATE_BASE in the V4L-spec. Expect a
revised patch using controls within a week or so...
--Frej
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features
2008-03-09 18:32 ` [PATCH 0 of 2] cx88: Enable additional cx2388x features Trent Piepho
2008-03-09 19:19 ` Frej Drejhammar
@ 2008-03-10 1:01 ` hermann pitton
1 sibling, 0 replies; 6+ messages in thread
From: hermann pitton @ 2008-03-10 1:01 UTC (permalink / raw)
To: Trent Piepho; +Cc: Frej Drejhammar, Linux and Kernel Video
Am Sonntag, den 09.03.2008, 11:32 -0700 schrieb Trent Piepho:
> On Sat, 8 Mar 2008, Frej Drejhammar wrote:
>
> > The cx2388x family of broadcast decoders all have features not enabled
> > by the standard cx88 driver. This patch series adds module parameters
> > allowing the chroma AGC and the color killer to be enabled. By default
> > both features are disabled as in previous versions of the driver.
> >
> > The Chroma AGC and the color killer is sometimes needed when using
> > signal sources of less than optimal quality.
>
> This really should be done with controls, not more module parameters.
>
This is a fully harmless example, still.
In general, we are flooded with patches currently, which seem to be
clever, but those people have not even any hardware to test them and are
easily happy to go over whole subsystems ...
I would like to see them piss in their own shoes in the first place and
not into ours.
Cheers,
Hermann
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 6+ messages in thread