From: "Måns Rullgård" <mans@mansr.com>
To: Sean Young <sean@mess.org>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
linux-media <linux-media@vger.kernel.org>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v7 3/3] media: rc: Add tango keymap
Date: Fri, 06 Oct 2017 11:47:01 +0100 [thread overview]
Message-ID: <yw1xmv54pn8a.fsf@mansr.com> (raw)
In-Reply-To: <20171005215246.q7m4ewyfytnbs46a@gofer.mess.org> (Sean Young's message of "Thu, 5 Oct 2017 22:52:46 +0100")
Sean Young <sean@mess.org> writes:
> Hi Marc,
>
> Looks great, just some minor nitpicks.
>
> On Thu, Oct 05, 2017 at 04:54:11PM +0200, Marc Gonzalez wrote:
>> Add a keymap for the Sigma Designs Vantage (dev board) remote control.
>>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>> ---
>> drivers/media/rc/keymaps/Makefile | 1 +
>> drivers/media/rc/keymaps/rc-tango.c | 84 +++++++++++++++++++++++++++++++++++++
>> drivers/media/rc/tango-ir.c | 2 +-
>> include/media/rc-map.h | 1 +
>> 4 files changed, 87 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/media/rc/keymaps/rc-tango.c
>>
>> diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
>> index af6496d709fb..3c1e31321e21 100644
>> --- a/drivers/media/rc/keymaps/Makefile
>> +++ b/drivers/media/rc/keymaps/Makefile
>> @@ -88,6 +88,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \
>> rc-reddo.o \
>> rc-snapstream-firefly.o \
>> rc-streamzap.o \
>> + rc-tango.o \
>> rc-tbs-nec.o \
>> rc-technisat-ts35.o \
>> rc-technisat-usb2.o \
>> diff --git a/drivers/media/rc/keymaps/rc-tango.c b/drivers/media/rc/keymaps/rc-tango.c
>> new file mode 100644
>> index 000000000000..c76651695959
>> --- /dev/null
>> +++ b/drivers/media/rc/keymaps/rc-tango.c
>> @@ -0,0 +1,84 @@
>
> I think you need a header with copyright statement and GPL version(s).
Is this even copyrightable?
--
Måns Rullgård
next prev parent reply other threads:[~2017-10-06 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 14:44 [PATCH v7 1/3] media: dt: bindings: Add binding for tango HW IR decoder Marc Gonzalez
2017-10-05 14:52 ` [PATCH v7 2/3] media: rc: Add driver " Marc Gonzalez
2017-10-05 14:54 ` [PATCH v7 3/3] media: rc: Add tango keymap Marc Gonzalez
2017-10-05 21:52 ` Sean Young
2017-10-06 10:47 ` Måns Rullgård [this message]
2017-10-06 10:55 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xmv54pn8a.fsf@mansr.com \
--to=mans@mansr.com \
--cc=linux-media@vger.kernel.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=sean@mess.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox