From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F024C47DD3 for ; Mon, 22 Jan 2024 08:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2yugJCPd8jiYL0SGmTLIZgbC+PDBHwJ6+q45hgq8ymY=; b=odrU1Ywb7QchejXKzbj7gKhn2S yJC1H1aPpxzhLbMsvg1sG7vOcd74MYc01V0D9R9Vlev997BRccPIvvE1YxNxVSmDiOx8RbtDfpbEq WTj7JuPXhtAwUKFG0aAW5qASEvPvja9/e/hdi6MclNDXYqZJZXKAK/pjBsk7joxarx0SGqgUwqAfj FX/cT68BLraVYl+QbFDwAVB1nSpG8bW7uQgoVQa8OC55xCoXZPuwFL7jW1QRbsnKZg0pMqfnzmKjv 319KgOrSq11uXQYKUN57jGRN1Z0DFUzDL+DieDcJ5Lskrs5TIPbD+LqK2JJItCP8IwYbcjqlOLoHa I5a5J8Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRppZ-00B6B5-2E; Mon, 22 Jan 2024 08:38:57 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRppW-00B69g-1m; Mon, 22 Jan 2024 08:38:55 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40e880121efso32472665e9.3; Mon, 22 Jan 2024 00:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705912733; x=1706517533; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2yugJCPd8jiYL0SGmTLIZgbC+PDBHwJ6+q45hgq8ymY=; b=bANm35pPxbBnQqLQmVIbRGVtc0zvnvVLKTYplvz9j793n/14ucHWPObBhtt1dpAyj/ MEGmLqLsis2IYTSTWX7dscDxl0iqQg2qW0J9gYDRa4D9FrAxgTO4+P/hZpTas7y6GvQS cMurhTRUHKfYdvm1uB5/e7tPyCV2iiHib0FfxuapsxBvo6/vH3/HGX+2n0OBzYjVLvdP IKcI0ye8IOmJShepUx63BwX7jf2wqb8qTpnO2zB6wJMsrjxMZlHoh0u+2MWC+VJrB2xn 0HGfqHRv+kdN4ApjF6D6BI/NYDKD/BgaLevhvkc47I1QZiMXcsQh+PZzm84TtGOXqKP+ Kv8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705912733; x=1706517533; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2yugJCPd8jiYL0SGmTLIZgbC+PDBHwJ6+q45hgq8ymY=; b=GjO2XG6AMmWU8xySWoUL6j7GH9FDajKukpbPGmjP6LHVzJN//icYyOpJeYTmJLVDQZ qp/WjXLvd7zkosx5dONgsT5/fOq9kDbEtHhtOB4T4Ktm/+oKg/KRHOdoNbedQc9JH1Xs R3R6z4hJynYIAUFKaEeiI3+OaSQrcu8xG4Z6kzGuV6FgJTlTYtU/2REVmgk67EOMAUiw vFnxW3BAe9Oh8Zxmn8ya+vaG+ahULt2DkJe2mAcahvrLt8ccsxawZk5cWi2YW/jEtTaP HYDmbfjXIpJ3D3CpdZYMkpT7eED8uZhQ69W+cdfXCxKBU8IyyWxH0ter13dhPXRSvWDf 5QYw== X-Gm-Message-State: AOJu0YwhQt8ya26ryhiE+xPzLjvHpiWgd5tbKwuQLK6k+1QPYPH7x/uQ lG5oK3DMgozaXCRsJELlp4BYutf2x61+Ld/Y7RLdSriYPHi4VwBy X-Google-Smtp-Source: AGHT+IHGL/CN7Ch/XQHu070cYX0yhaZRpgJ8dXbFAwR62/I6GOIuKFyU3SRJTiPHD1YNSW1Stzt6QA== X-Received: by 2002:a05:600c:1906:b0:40e:4b0d:286d with SMTP id j6-20020a05600c190600b0040e4b0d286dmr2034987wmq.35.1705912732771; Mon, 22 Jan 2024 00:38:52 -0800 (PST) Received: from [192.168.2.177] ([207.188.161.188]) by smtp.gmail.com with ESMTPSA id iv17-20020a05600c549100b0040e5034d8e0sm42483332wmb.43.2024.01.22.00.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 00:38:51 -0800 (PST) Message-ID: <011d5f5b-cf10-4476-8b5c-2fc9805e71e2@gmail.com> Date: Mon, 22 Jan 2024 09:38:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] cpufreq: mediatek-hw: Wait for CPU supplies before probing Content-Language: en-US, ca-ES, es-ES To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Viresh Kumar , "Rafael J . Wysocki" , AngeloGioacchino Del Regno Cc: kernel@collabora.com, "Hector.Yuan" , Liam Girdwood , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20240110142305.755367-1-nfraprado@collabora.com> <20240110142305.755367-3-nfraprado@collabora.com> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRd1TlIARAAm78mTny44Hwd IYNK4ZQH6U5pxcJtU45LLBmSr4DK/7er9chpvJ5pgzCGuI25ceNTEg5FChYcgfNMKqwCAekk V9Iegzi6UK448W1eOp8QeQDS6sHpLSOe8np6/zvmUvhiLokk7tZBhGz+Xs5qQmJPXcag7AMi fuEcf88ZSpChmUB3WflJV2DpxF3sSon5Ew2i53umXLqdRIJEw1Zs2puDJaMqwP3wIyMdrfdI H1ZBBJDIWV/53P52mKtYQ0Khje+/AolpKl96opi6o9VLGeqkpeqrKM2cb1bjo5Zmn4lXl6Nv JRH/ZT68zBtOKUtwhSlOB2bE8IDonQZCOYo2w0opiAgyfpbij8uiI7siBE6bWx2fQpsmi4Jr ZBmhDT6n/uYleGW0DRcZmE2UjeekPWUumN13jaVZuhThV65SnhU05chZT8vU1nATAwirMVeX geZGLwxhscduk3nNb5VSsV95EM/KOtilrH69ZL6Xrnw88f6xaaGPdVyUigBTWc/fcWuw1+nk GJDNqjfSvB7ie114R08Q28aYt8LCJRXYM1WuYloTcIhRSXUohGgHmh7usl469/Ra5CFaMhT3 yCVciuHdZh3u+x+O1sRcOhaFW3BkxKEy+ntxw8J7ZzhgFOgi2HGkOGgM9R03A6ywc0sPwbgk gF7HCLirshP2U/qxWy3C8DkAEQEAAcLBdgQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TlIAhsMAAoJENkUC7JWEwLxtdcP/jHJ9vI8adFi1HQoWUKCQbZdZ5ZJHayFKIzU9kZE /FHzzzMDZYFgcCTs2kmUVyGloStXpZ0WtdCMMB31jBoQe5x9LtICHEip0irNXm80WsyPCEHU 3wx91QkOmDJftm6T8+F3lqhlc3CwJGpoPY7AVlevzXNJfATZR0+Yh9NhON5Ww4AjsZntqQKx E8rrieLRd+he57ZdRKtRRNGKZOS4wetNhodjfnjhr4Z25BAssD5q+x4uaO8ofGxTjOdrSnRh vhzPCgmP7BKRUZA0wNvFxjboIw8rbTiOFGb1Ebrzuqrrr3WFuK4C1YAF4CyXUBL6Z1Lto//i 44ziQUK9diAgfE/8GhXP0JlMwRUBlXNtErJgItR/XAuFwfO6BOI43P19YwEsuyQq+rubW2Wv rWY2Bj2dXDAKUxS4TuLUf2v/b9Rct36ljzbNxeEWt+Yq4IOY6QHnE+w4xVAkfwjT+Vup8sCp +zFJv9fVUpo/bjePOL4PMP1y+PYrp4PmPmRwoklBpy1ep8m8XURv46fGUHUEIsTwPWs2Q87k 7vjYyrcyAOarX2X5pvMQvpAMADGf2Z3wrCsDdG25w2HztweUNd9QEprtJG8GNNzMOD4cQ82T a7eGvPWPeXauWJDLVR9jHtWT9Ot3BQgmApLxACvwvD1a69jaFKov28SPHxUCQ9Y1Y/Ct In-Reply-To: <20240110142305.755367-3-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_003854_589233_0A85AE3B X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/01/2024 15:23, Nícolas F. R. A. Prado wrote: > Before proceeding with the probe and enabling frequency scaling for the > CPUs, make sure that all supplies feeding the CPUs have probed. > > This fixes an issue observed on MT8195-Tomato where if the > mediatek-cpufreq-hw driver enabled the hardware (by writing to > REG_FREQ_ENABLE) before the SPMI controller driver (spmi-mtk-pmif), > behind which lies the big CPU supply, probed the platform would hang > shortly after with "rcu: INFO: rcu_preempt detected stalls on > CPUs/tasks" being printed in the log. > > Fixes: 4855e26bcf4d ("cpufreq: mediatek-hw: Add support for CPUFREQ HW") > Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Matthias Brugger > > --- > > Changes in v2: > - Added this commit > > drivers/cpufreq/mediatek-cpufreq-hw.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediatek-cpufreq-hw.c > index d46afb3c0092..a1aa9385980a 100644 > --- a/drivers/cpufreq/mediatek-cpufreq-hw.c > +++ b/drivers/cpufreq/mediatek-cpufreq-hw.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > > #define LUT_MAX_ENTRIES 32U > @@ -300,7 +301,23 @@ static struct cpufreq_driver cpufreq_mtk_hw_driver = { > static int mtk_cpufreq_hw_driver_probe(struct platform_device *pdev) > { > const void *data; > - int ret; > + int ret, cpu; > + struct device *cpu_dev; > + struct regulator *cpu_reg; > + > + /* Make sure that all CPU supplies are available before proceeding. */ > + for_each_possible_cpu(cpu) { > + cpu_dev = get_cpu_device(cpu); > + if (!cpu_dev) > + return dev_err_probe(&pdev->dev, -EPROBE_DEFER, > + "Failed to get cpu%d device\n", cpu); > + > + cpu_reg = devm_regulator_get_optional(cpu_dev, "cpu"); > + if (IS_ERR(cpu_reg)) > + return dev_err_probe(&pdev->dev, PTR_ERR(cpu_reg), > + "CPU%d regulator get failed\n", cpu); > + } > + > > data = of_device_get_match_data(&pdev->dev); > if (!data)