From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62A6BCCF9EE for ; Tue, 28 Oct 2025 11:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YjFpI9BYeJIGawQior8vsJoD7SmwJll5ZNIMlbkQNe0=; b=HPjsVQG5zZsJTkLk94x2wuOsvI 0i/AU+pOL6giPf44VAdN5etVAyqXKb9BzbVoHxMG5HyBQUBG4I99WbbY164Ie/TnNGS1aCZ+l13yh DX1h3rd2hQPjCR5kgI2YYAFaAoHiXJmcfgQUPoTiu+HftC3IFLINowYwrP8cGNsZzyWZF1HkS5J7H mEtbosejXRzA2a/ucUexmIKDFkWXianpEwoFAshx+zkhDx5tAWTHW1pYfaquu/3T/YK37rKD78OdT ne37ezp+ewLArKdwp7G2NTW3rGQ6fobsHLt19VAd5uOaTx1ixNmc+9OvEYqO0AgHucxPK4xAe+Xbf VhynDhiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDhej-0000000FpNh-1d0X; Tue, 28 Oct 2025 11:14:25 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDheg-0000000FpML-1iFq for linux-mediatek@lists.infradead.org; Tue, 28 Oct 2025 11:14:23 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-b4aed12cea3so734732866b.1 for ; Tue, 28 Oct 2025 04:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761650060; x=1762254860; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YjFpI9BYeJIGawQior8vsJoD7SmwJll5ZNIMlbkQNe0=; b=D5w23G0qbK1ZR4EQQ7ftA/efD33EO05BkwtmHT4hARdzB81kGtKTTRzedXeVp767zo xuhnr9Y/w6lFTa4gUomIxICzzsZM4z7ip8tED/MKCkMduDAIHLzYd+PTGHlFk/LjHMBQ gtOILzhX9wYaf26kpf+MR0ihuMfnvreBCATEszK2eUUaOda5YKrYDLoNCVVoSyfLVkGL eSyRiOlbogqN6GV4R6ilhfrN3GxnCRFF5L4fS07ABj3GeJHChprSt3C0gkLF1YgOruzp fBVciqjXkObPq8aEl7/9zQHxHUFGYtjhFlv/ai3ps/7NlpnN+YiLE40B/tKfkPep385+ 8/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761650060; x=1762254860; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjFpI9BYeJIGawQior8vsJoD7SmwJll5ZNIMlbkQNe0=; b=ovqx3lf5C4fUGZp1eWgNye6KWPp2IGmmW6JmsC3kFuxRVMLmh6PG4Gmp1evsplTYBy VnC2Oeys8JFc8W+qx4kIYlElTlNlmrgrkQsUc09QmsA4HCt3niRXtMhz8t/sfgT6IKEC 1N7HVeWGk5iX9YR1voRXCMkJHjWMq8jOMzC3457rzWPq4M5yszEOWJuzv3Qnkglqbyid lKmW2phTepU1T3mWkH9DaweMFBp6551uNlz5BHjt5wainX83zVuE84KHt4krhjsRweUG GsDL8EC3V+yGI7HL9uq3nA7VZOZUt5K23qLK1npU9pFRr+vIBsLf+Z9DFrEGGuep2Rht kTJQ== X-Forwarded-Encrypted: i=1; AJvYcCUOotgUZ8uPv2DVfxEzd6LCddzOZt5BIOVKpmrupm758nHxNIeW2RUyM+pimu/gCMb14qWTK+JRidStE5lWCA==@lists.infradead.org X-Gm-Message-State: AOJu0YzKmUD9QMNCF9E+MpM9kievlHjGzRtagYZqBBVA1fGLyUJgfX33 EjWhZvkNq89bJ/yyR25BWGS+3JY2wcJxEDGD3tbQJOtzFG7VLKUq2WLu X-Gm-Gg: ASbGncsJ0VoLwFyQmwaHPCrRPxoVK/gfjs56waNvxZpf3wc6ZBbR3UWg+4KPSQFnCTG KQtGyuhjxzcXQpAp1s88OKKCKqr/CM1UdfycM5rqmUvdeAA7lOeI+f2ZSX3GFWNi95Koafge38P PQJ0Qy9tF68cjSnsNqaZ65/x6X6DiSVJmHVye1XeTIcN1AyYpI2sOXniV46M14wDWlGLBIdOyke Rx8qKFfZyWLWMaEIr7WAytcfzWZw/ALGkJ/WOJJh1VAciwEmYlAVwWvf5OdGr5asuDOr1gTrc5h +WYAKlvi921NkTDonSZqNAaQWqbp7f781yuyFYQdPqunTdUkUsH7UPwvwBkTNUUWpvuSTRLkx+H EuAu4N1KZWT13OQwAMmoD+bEAlNGz/pGDvvNo9Xoc9ZqT6GuGd+5s7Eb0kRBVPCxB2xnmnxRNCU cYL4dXgszplkC5j79K3Nh/jdSE6DL/QottyHmJPkc1dixIT8aV/9+FZrG8VG1fuxl+mC5KlfqTY TGuTeR4RtyAxJJmti8wL4A/9G/TJMSYNoXOXkkM63NLApCgrtx2ow== X-Google-Smtp-Source: AGHT+IGFhB1uFC3jfUFSa2Q1GaChneZzYP9rrCvUKq1g/2kn74sMQ9tiDca6CquKILqpFbpXF/Q/Kg== X-Received: by 2002:a17:907:7f0a:b0:b4a:ed12:ce51 with SMTP id a640c23a62f3a-b6dba498fe6mr339684266b.23.1761650059938; Tue, 28 Oct 2025 04:14:19 -0700 (PDT) Received: from ?IPV6:2001:1c00:20d:1300:1b1c:4449:176a:89ea? (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d853077ddsm1052436566b.11.2025.10.28.04.14.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 04:14:19 -0700 (PDT) Message-ID: <05610ae5-4a8a-47e9-808b-7ff98fade78e@gmail.com> Date: Tue, 28 Oct 2025 12:14:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/15] arm64: dts: mediatek: mt7981b-openwrt-one: Enable Ethernet To: Sjoerd Simons , Andrew Lunn , "Lucien.Jheng" Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Lee Jones , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , Felix Fietkau , kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, netdev@vger.kernel.org, Daniel Golle , Bryan Hinton References: <20251016-openwrt-one-network-v1-0-de259719b6f2@collabora.com> <20251016-openwrt-one-network-v1-12-de259719b6f2@collabora.com> <4f82aa17-1bf8-4d72-bc1f-b32f364e1cf6@lunn.ch> <8f5335a703905dea9d8d0c1840862a3478da1ca7.camel@collabora.com> From: Eric Woudstra Content-Language: en-US In-Reply-To: <8f5335a703905dea9d8d0c1840862a3478da1ca7.camel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251028_041422_476580_12CA18FB X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/21/25 10:21 PM, Sjoerd Simons wrote: > On Fri, 2025-10-17 at 19:31 +0200, Andrew Lunn wrote: >>> +&mdio_bus { >>> + phy15: ethernet-phy@f { >>> + compatible = "ethernet-phy-id03a2.a411"; >>> + reg = <0xf>; >>> + interrupt-parent = <&pio>; >>> + interrupts = <38 IRQ_TYPE_EDGE_FALLING>; >> >> This is probably wrong. PHY interrupts are generally level, not edge. > > Sadly i can't find a datasheet for the PHY, so can't really validate that easily. Maybe Eric can > comment here as the author of the relevant PHY driver. > > I'd note that the mt7986a-bananapi-bpi-r3-mini dts has the same setup for this PHY, however that's > ofcourse not authoritative. > Lucien would have access to the correct information about the interrupt.