RE: [PATCH 06/11] net: wwan: t9xx: Add AT & MBIM WWAN ports

["Wu. JackBB (GSM)" <JackBB_Wu@compal.com>]

Hi Jagielski,

Thank you for the review. Below are the changes and responses for v2.

> >Adds AT & MBIM ports to the port infrastructure.
>
> please use imperative mode in commit msg

Changed to "Add AT & MBIM ports to the port infrastructure."

> > +/* -EIO means partial data dispatch complete, does not goto drop flow */
>
> unclear how adding this comment is related to the patch

Agreed. Moved this comment to patch 4 where the code was
introduced.

> > +int ret = 0;
>
> like for the previous commits - please do not zeroinit when don't required
> returbning 0 at the end is completely fine here

Removed zero-initialization and return 0 directly.

> > +ret = -EFAULT;
>
> i believe there are better suiting codes

Changed to -EINVAL. If you have a more suitable error code in
mind, please let us know.

> > +if (len == 0)
> > +return 0;
>
> that's really successful path?

Changed to return -EINVAL for zero-length writes.

> > +static int mtk_port_wwan_init(struct mtk_port *port)
>
> for the whole series - please assess where int over void
> is really required

Reviewed the whole series. Changed port_ops exit, reset,
enable, and disable callbacks from int to void, as their
return values are never checked by callers. Kept init and
recv as int since their return values are used.

Thanks.

Jack Wu


================================================================================================================================================================
This message may contain information which is private, privileged or confidential of Compal Electronics, Inc. If you are not the intended recipient of this message, please notify the sender and destroy/delete the message. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information, by persons or entities other than the intended recipient is prohibited.
================================================================================================================================================================