From: Alexandre Mergnat <amergnat@baylibre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
chunkuang.hu@kernel.org
Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wenst@chromium.org,
kernel@collabora.com, ehristev@collabora.com,
"Jason-JH . Lin" <jason-jh.lin@mediatek.com>
Subject: Re: [PATCH RESEND v6 04/11] drm/mediatek: gamma: Improve and simplify HW LUT calculation
Date: Fri, 28 Jul 2023 15:00:42 +0200 [thread overview]
Message-ID: <06162f85-bb38-d07a-38f6-e7303c80996c@baylibre.com> (raw)
In-Reply-To: <20230727094633.22505-5-angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On 27/07/2023 11:46, AngeloGioacchino Del Regno wrote:
> Use drm_color_lut_extract() to avoid open-coding the bits reduction
> calculations for each color channel and use a struct drm_color_lut
> to temporarily store the information instead of an array of u32.
>
> Also, slightly improve the precision of the HW LUT calculation in the
> LUT DIFF case by performing the subtractions on the 16-bits values and
> doing the 10 bits conversion later.
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-07-28 13:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 9:46 [PATCH RESEND v6 00/11] MediaTek DDP GAMMA - 12-bit LUT support AngeloGioacchino Del Regno
2023-07-27 9:46 ` [PATCH RESEND v6 01/11] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters AngeloGioacchino Del Regno
2023-07-28 13:00 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 02/11] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common() AngeloGioacchino Del Regno
2023-07-28 13:00 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 03/11] drm/mediatek: gamma: Support SoC specific LUT size AngeloGioacchino Del Regno
2023-07-28 13:00 ` Alexandre Mergnat
2023-07-31 7:49 ` CK Hu (胡俊光)
2023-07-31 10:40 ` AngeloGioacchino Del Regno
2023-07-31 12:05 ` AngeloGioacchino Del Regno
2023-07-27 9:46 ` [PATCH RESEND v6 04/11] drm/mediatek: gamma: Improve and simplify HW LUT calculation AngeloGioacchino Del Regno
2023-07-28 13:00 ` Alexandre Mergnat [this message]
2023-07-27 9:46 ` [PATCH RESEND v6 05/11] drm/mediatek: gamma: Enable the Gamma LUT table only after programming AngeloGioacchino Del Regno
2023-07-28 13:00 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 06/11] drm/mediatek: gamma: Use bitfield macros AngeloGioacchino Del Regno
2023-07-28 13:01 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 07/11] drm/mediatek: gamma: Support specifying number of bits per LUT component AngeloGioacchino Del Regno
2023-07-28 13:01 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 08/11] drm/mediatek: gamma: Support multi-bank gamma LUT AngeloGioacchino Del Regno
2023-07-28 13:01 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 09/11] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195 AngeloGioacchino Del Regno
2023-07-27 11:03 ` Alexandre Mergnat
2023-07-27 13:06 ` AngeloGioacchino Del Regno
2023-07-28 12:58 ` Alexandre Mergnat
2023-07-31 10:27 ` AngeloGioacchino Del Regno
2023-07-31 11:57 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 10/11] drm/mediatek: gamma: Make sure relay mode is disabled AngeloGioacchino Del Regno
2023-07-28 13:01 ` Alexandre Mergnat
2023-07-27 9:46 ` [PATCH RESEND v6 11/11] drm/mediatek: gamma: Program gamma LUT type for descending or rising AngeloGioacchino Del Regno
2023-07-28 13:02 ` Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06162f85-bb38-d07a-38f6-e7303c80996c@baylibre.com \
--to=amergnat@baylibre.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ehristev@collabora.com \
--cc=jason-jh.lin@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox