public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Terje Bergstrom <tbergstrom@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Johnny-CC Chang (張晋嘉)" <Johnny-CC.Chang@mediatek.com>,
	"lukas@wunner.de" <lukas@wunner.de>,
	Project_Global_Digits_Upstream_Group
	<Project_Global_Digits_Upstream_Group@mediatek.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	"Alex Williamson" <alex@shazbot.org>
Subject: Re: [PATCH] PCI: Mark Nvidia GB10 to avoid bus reset
Date: Thu, 15 Jan 2026 13:55:09 -0800	[thread overview]
Message-ID: <080d7aef-0139-4da4-8f43-aedbf9bb9948@nvidia.com> (raw)
In-Reply-To: <20260115205347.GA881345@bhelgaas>

On 1/15/26 12:53, Bjorn Helgaas wrote:
> OK, so you do SBR to some endpoint below a GB10 Root Port, and after > the SBR, the link to the endpoint retrains with a lower lane count > and config reads to the endpoint time out?

That's right. The symptoms can vary, i.e. sometimes it retrains with lower
lane count, and sometimes config reads start timing out, and very often
it works just fine.

> I see you're from NVIDIA, so if you're confirming that this is a > hardware erratum (not an issue with the GB10 PCI controller driver), > we should definitely apply this, and I'll wordsmith the commit log > and comment something like this: > > When asserting Secondary Bus Reset to downstream devices via a GB10 > Root Port, the link doesn't retrain correctly. The link may retrain > with a lower lane count, and config accesses to downstream devices > may fail.

Yes, I confirm this is a HW erratum. The problem doesn't occur every time, so
"the link may not retrain correctly" would be more correct, but that's a minor
comment.

Terje


  reply	other threads:[~2026-01-15 21:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  8:44 [PATCH] PCI: Mark Nvidia GB10 to avoid bus reset Johnny Chang
     [not found] ` <aRWnYCI6Ax14XNJq@wunner.de>
2025-11-18  9:39   ` Johnny-CC Chang (張晋嘉)
2026-01-14  6:39     ` Johnny-CC Chang (張晋嘉)
2026-01-14 17:28       ` Bjorn Helgaas
2026-01-15 20:11         ` Terje Bergstrom
2026-01-15 20:53           ` Bjorn Helgaas
2026-01-15 21:55             ` Terje Bergstrom [this message]
2026-01-15 22:11 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=080d7aef-0139-4da4-8f43-aedbf9bb9948@nvidia.com \
    --to=tbergstrom@nvidia.com \
    --cc=Johnny-CC.Chang@mediatek.com \
    --cc=Project_Global_Digits_Upstream_Group@mediatek.com \
    --cc=alex@shazbot.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jgg@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox