From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A742CC433EF for ; Thu, 27 Jan 2022 10:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FYwxUOQjHOsfEezTl8QHwfSnS48WeTakfGE+RsQHB9A=; b=q0I39Iw04EtZAh27/gK407L6fx 4vwVqq5xfqQUNs1QsONX4rgtz3LqQXaj8BGKVXY+SDPrxVWwOuVnhOLHHPN4M7vGMdjANgSB64kh3 BrN4N2K76rZGtA6xsJAduAWqi3++6/+IaVDd3Nr10O1+EpIoqXfFQf33M0q7ZioM1dQvlJqDhzAKW 8fpEfwAr7WwFHehhIsFwxU5IK9NoAQ9uf9qg+bPRZeujEm8tSXPl/XdTNTVEaZVkKABKgnHJw7taj 99b6v45LLvcJBtZIK3Owxc8ZCylFlAYEMr4yy22O3dd6HhTVCmI+zDiAUTo47TwThsbWE28rqrD01 4MJ+eY2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD2TN-00FGBs-Pm; Thu, 27 Jan 2022 10:57:49 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD2T2-00FG3P-JH; Thu, 27 Jan 2022 10:57:30 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9FD541F40893 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643281047; bh=nTKHCZzC6UeHy9OCKez9WNf/yCUacrzA2Hv/pSEJ8lw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=me780pf2wBR6g5L94Ao21BGx4lcKc0EO2mgsnNFeG6YuRrhQ55hU5PDNoxbTOES0S gMTtjKpWSidNHbtvCBR6cvxouUpIqfpyrQD9Utb0dHwzSsloPC51H/fUjObkoON+fw fOSWr/4eEkfKKVex0JQlF6+Slsj923sz0fuExqI5j3+vAZ5Wh2tX8Lgo0gqPXEfhGs e2jwKbs785o5n+UUiKzbuskru2JtFPsRaWWz0tQJ9GVQV5HfVukUaeGT4OTYrRIjZf gxZm19cDufkeMEh4nQR4NQzm5JONfocZVoKBfGidMLIDx9VBg+sFqDF7N32x4k794z VmYj9Gg4l4GBQ== Subject: Re: [PATCH v11 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes To: moudy ho , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec Cc: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Courbot , tfiga@chromium.org, drinkcat@chromium.org, pihsun@chromium.org, hsinyi@google.com, Maoguang Meng , daoyuan huang , Ping-Hsun Wu , menghui.lin@mediatek.com, sj.huang@mediatek.com, allen-kh.cheng@mediatek.com, randy.wu@mediatek.com, jason-jh.lin@mediatek.com, roy-cw.yeh@mediatek.com, river.cheng@mediatek.com, srv_heupstream@mediatek.com References: <20220105093758.6850-1-moudy.ho@mediatek.com> <20220105093758.6850-3-moudy.ho@mediatek.com> <356f512b549f90b329775e249fd48eb2954ade02.camel@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <08fc74c5-4f2f-8712-454d-8cf3aed4eb10@collabora.com> Date: Thu, 27 Jan 2022 11:57:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <356f512b549f90b329775e249fd48eb2954ade02.camel@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_025728_948684_C135F8FD X-CRM114-Status: GOOD ( 19.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 25/01/22 09:20, moudy ho ha scritto: > On Fri, 2022-01-21 at 12:58 +0100, AngeloGioacchino Del Regno wrote: >> Il 05/01/22 10:37, Moudy Ho ha scritto: >>> Add device nodes for Media Data Path 3 (MDP3) modules. >>> >>> Signed-off-by: Moudy Ho >>> --- >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 108 >>> ++++++++++++++++++++++- >>> 1 file changed, 107 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> index ba4584faca5a..b872ef1ff6b3 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> @@ -1325,6 +1325,79 @@ >>> mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX >>> 0 0x1000>; >>> }; >>> >>> + mdp3_rdma0: mdp3_rdma0@14001000 { >>> + compatible = "mediatek,mt8183-mdp3", >>> + "mediatek,mt8183-mdp3-rdma0"; >>> + mediatek,scp = <&scp>; >>> + mediatek,mdp3-comps = "mediatek,mt8183-mdp3- >>> dl1", >>> + "mediatek,mt8183-mdp3- >>> dl2", >>> + "mediatek,mt8183-mdp3- >>> path1", >>> + "mediatek,mt8183-mdp3- >>> path2", >>> + "mediatek,mt8183-mdp3- >>> imgi", >>> + "mediatek,mt8183-mdp3- >>> exto"; >>> + reg = <0 0x14001000 0 0x1000>, >>> + <0 0x14000000 0 0x1000>, >>> + <0 0x14005000 0 0x1000>, >>> + <0 0x14006000 0 0x1000>, >>> + <0 0x15020000 0 0x1000>; >>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX >>> 0x1000 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0x5000 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0x6000 0x1000>, >>> + <&gce SUBSYS_1502XXXX >>> 0 0x1000>; >>> + power-domains = <&spm >>> MT8183_POWER_DOMAIN_DISP>; >>> + clocks = <&mmsys CLK_MM_MDP_RDMA0>, >>> + <&mmsys CLK_MM_MDP_RSZ1>, >>> + <&mmsys CLK_MM_MDP_DL_TXCK>, >>> + <&mmsys CLK_MM_MDP_DL_RX>, >>> + <&mmsys CLK_MM_IPU_DL_TXCK>, >>> + <&mmsys CLK_MM_IPU_DL_RX>; >>> + iommus = <&iommu M4U_PORT_MDP_RDMA0>; >>> + mediatek,mmsys = <&mmsys>; >>> + mediatek,mm-mutex = <&mutex>; >>> + mediatek,mailbox-gce = <&gce>; >>> + mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST 0>, >>> + <&gce 21 CMDQ_THR_PRIO_LOWEST>, >>> + <&gce 22 CMDQ_THR_PRIO_LOWEST>, >>> + <&gce 23 CMDQ_THR_PRIO_LOWEST>; >> >> Hello Moudy, >> the mboxes for gce 21, 22, 23 are missing the third cell. Please fix. >> >> Regards, >> Angelo > > Hi Angelo, > Thanks for the reminder, but I'm a bit confused, the previous > version(v10) mentioned that the current upstream mbox has only 2 > cells. > So I should follow this rule to remove the extra 0 in the first item as > follows: > + mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST>, > + <&gce 21 CMDQ_THR_PRIO_LOWEST>, > + <&gce 22 CMDQ_THR_PRIO_LOWEST>, > + <&gce 23 CMDQ_THR_PRIO_LOWEST>; > > Thanks, > Moudy Ho Hello Moudy, I'm sorry for this confusion and you are totally right in the proposed solution, which is the exact opposite of what I said. Thanks for understanding, Angelo >> >>> + gce-subsys = <&gce 0x14000000 SUBSYS_1400XXXX>, >>> + <&gce 0x14010000 SUBSYS_1401XXXX>, >>> + <&gce 0x14020000 SUBSYS_1402XXXX>, >>> + <&gce 0x15020000 SUBSYS_1502XXXX>; >>> + }; >>> + >> >> > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek