Re: [PATCH 3/4] dt-bindings: arm: mediatek: audsys: Support mt8192-audsys variant

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 10/02/26 14:41, Rob Herring ha scritto:
> On Thu, Jan 15, 2026 at 6:56 AM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Add support for the mediatek,mt8192-audsys compatible, which uses
>> a different audio controller (mt8192-afe-pcm) compared to mt8183
>> and mt2701.
>>
>> This resolves a dtbs_check warning on all MT8192 devicetrees.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../arm/mediatek/mediatek,audsys.yaml         | 46 +++++++++++++------
>>   1 file changed, 33 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
>> index f3a761cbd0fd..09a6c16e7e82 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
>> @@ -48,19 +48,39 @@ required:
>>     - compatible
>>     - '#clock-cells'
>>
>> -if:
>> -  properties:
>> -    compatible:
>> -      contains:
>> -        const: mediatek,mt8183-audiosys
>> -then:
>> -  properties:
>> -    audio-controller:
>> -      $ref: /schemas/sound/mediatek,mt8183-audio.yaml#
>> -else:
>> -  properties:
>> -    audio-controller:
>> -      $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
>> +allOf:
>> + - if:
> 
> Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml:52:2:
> [warning] wrong indentation: expected 2 but found 1 (indentation)
> 
> 
>> +     properties:
>> +       compatible:
>> +         contains:
>> +           enum:
>> +             - mediatek,mt2701-audsys
>> +             - mediatek,mt7622-audsys
>> +   then:
>> +     properties:
>> +       audio-controller:
>> +         $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
>> +
>> + - if:
>> +     properties:
>> +       compatible:
>> +         contains:
>> +           const: mediatek,mt8183-audiosys
>> +   then:
>> +     properties:
>> +       audio-controller:
>> +         $ref: /schemas/sound/mediatek,mt8183-audio.yaml#
>> +
>> + - if:
>> +     properties:
>> +       compatible:
>> +         contains:
>> +           const: mediatek,mt8192-audsys
>> +   then:
>> +     properties:
>> +       audio-controller:
>> +         $ref: /schemas/sound/mt8192-afe-pcm.yaml#
>> +
>>
> 
> Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml:84:1:
> [warning] too many blank lines (2 > 1) (empty-lines)
> 
> Please fix as these are warnings in linux-next now.
> 

Ack. Sorry for the mistakes. Not sure how this happened.

Let me see when I can get some minutes to get this addressed.

Cheers,
Angelo

> 
>>   additionalProperties: false
>>
>> --
>> 2.52.0
>>