From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC461E77188 for ; Mon, 30 Dec 2024 19:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uvDeDR9Oa70KelI0kN2Nd7YiH226dpawgt4F8xNVEXc=; b=BLTmyZfWvmFZlVsA9kzmUHQUR5 e/zOq9tdwkeeoMK7sBQzctZZ4ZhxQiW9TG2ViPoVVz7fb5Lmfm5FqKvLdI5Donf9d1xYZSFhIZY6v YMT1MFzw7fxo4+uYXkTRxkblhhThsi1pYPK5wj96xj+gy0T9D7kq7WIevlkeIbev1B0t3VaFP/3kI FhZVUpyL+JgOl000d+fJUq3MXN0S4dPKM02uoo+xsBao3/OieFm76mCa0ABNzf3EHnkTuH2yJZLr6 N5ZyqchArXTtYPMdHg1vdcBUgzgpCseamuQdcD37xE9M4GZPL5yqccFkPLsi4Iv0YimIE1g4DO0cb avBXQvQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tSL5E-00000005iOq-1iM7; Mon, 30 Dec 2024 19:05:44 +0000 Received: from nbd.name ([46.4.11.11]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tSL5B-00000005iOV-2A7T for linux-mediatek@lists.infradead.org; Mon, 30 Dec 2024 19:05:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uvDeDR9Oa70KelI0kN2Nd7YiH226dpawgt4F8xNVEXc=; b=bgUDk4okfWHD2WCrHdBvM6GV0b WbuZ7TyM6QWA8yPr7UO8sUOBOdogfTF2mA/G3A6+byxX8W1KN+jHsi3N6EVoFrlR0JNFt/b9E9+w7 KgIC7R6Qim+i4zkXzSykmkB0rf0IyrTtr17ZGb3cBhhn32UB19EGPUvZhCLn1pq5WSRk=; Received: from p4ff13c5f.dip0.t-ipconnect.de ([79.241.60.95] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tSL4s-00GKGy-24; Mon, 30 Dec 2024 20:05:22 +0100 Message-ID: <0ec8b1bd-6bd8-49e9-86c1-33ba36709331@nbd.name> Date: Mon, 30 Dec 2024 20:05:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: mt76: mt7921: avoid undesired changes of the preset regulatory domain To: Mingyen Hsieh , lorenzo@kernel.org Cc: deren.wu@mediatek.com, Sean.Wang@mediatek.com, Soul.Huang@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, km.lin@mediatek.com, robin.chiu@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, Quan.Zhou@mediatek.com, Ryder.Lee@mediatek.com, Shayne.Chen@mediatek.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20240412085357.13756-1-mingyen.hsieh@mediatek.com> Content-Language: en-US From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <20240412085357.13756-1-mingyen.hsieh@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241230_110541_638887_0C66674B X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 12.04.24 10:53, Mingyen Hsieh wrote: > From: Leon Yen > > Some countries have strict RF restrictions where changing the regulatory > domain dynamically based on the connected AP is not acceptable. > This patch disables Beacon country IE hinting when a valid country code > is set from usersland (e.g., by system using iw or CRDA). > > Signed-off-by: Leon Yen > Signed-off-by: Ming Yen Hsieh > --- > drivers/net/wireless/mediatek/mt76/mt7921/init.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > index ef0c721d26e3..3c9a5fcd6924 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > @@ -135,6 +135,13 @@ mt7921_regd_notifier(struct wiphy *wiphy, > dev->mt76.region = request->dfs_region; > dev->country_ie_env = request->country_ie_env; > > + if (request->initiator == NL80211_REGDOM_SET_BY_USER) { > + if (dev->mt76.alpha2[0] == '0' && dev->mt76.alpha2[1] == '0') > + wiphy->regulatory_flags &= ~REGULATORY_COUNTRY_IE_IGNORE; > + else > + wiphy->regulatory_flags |= REGULATORY_COUNTRY_IE_IGNORE; > + } > + Sorry for the late response, I just noticed that I completely forgot to review this one. In principle, it makes sense to me to ignore the country IE in this case, however I don't understand why the change is done in the mt7921 driver. Isn't this a generic issue that should be consistent across drivers and thus better handled in mac80211? Thanks, - Felix