From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4C1AEB64DA for ; Sun, 16 Jul 2023 09:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TAJr9RfjXmpVJaGDPJRNgS+LUQLrLAkAk0FUDyDmUXQ=; b=SdKXXwozMaCeSJzi5aBNXmII7x 2otrVAW4WRoQstj9i8CzJ59Jy90tPipZhzqbI+wLz6yAelP2NRJNQQ/8SxCjQcICvp/fHqE7LpXSx Xk01sHHOOjfDyaeYbJBJ2Wj2iY0Vh47XHEHgiivpzw5ObdYGqwLIKvdK3XWtJB3zOJZ3pYTrFC8WE sosFghp40XoPXFbZJVj4l1ZZ8pjLuGufJ77Q0Gl/JGKk+Rf2awUb/hq43uL7D+cBapEWiYbzdMNFE gGxNCQKR/QSGGdhOZbq5po0o5MttcRhLUUxOKOPxB9EuCKpBjy0YHYdktEi68UibVNeb2IMx9GmCl xULujvdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKy1S-00ARCP-02; Sun, 16 Jul 2023 09:26:34 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKy1K-00ARAR-1B; Sun, 16 Jul 2023 09:26:28 +0000 Received: from i53875a6a.versanet.de ([83.135.90.106] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qKy04-0005tq-1S; Sun, 16 Jul 2023 11:25:08 +0200 From: Heiko Stuebner To: Liviu Dudau , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Inki Dae , Marek Szyprowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas Stach , Russell King , Christian Gmeiner , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Laurentiu Palcu , Paul Cercueil , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Marek Vasut , Stefan Agner , Sam Ravnborg , Jerry Han , Icenowy Zheng , Ondrej Jirman , Javier Martinez Canillas , Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Jianhua Lu , Florian Fainelli , Broadcom internal kernel review list , Artur Weber , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Emma Anholt , Kieran Bingham , Sandy Huang , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Oleksandr Andrushchenko , Rob Herring Cc: devicetree@vger.kernel.org, Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH] drm: Explicitly include correct DT includes Date: Sun, 16 Jul 2023 11:25:03 +0200 Message-ID: <114500369.nniJfEyVGO@phil> In-Reply-To: <20230714174545.4056287-1-robh@kernel.org> References: <20230714174545.4056287-1-robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230716_022627_486716_453C7891 X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- [...] > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > index 917e79951aac..2744d8f4a6fa 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > @@ -12,7 +12,9 @@ > #include > #include > #include > +#include > #include > +#include > #include > #include I'm not sure if I'm just misreading something, but in all other places of_device.h gets removed while here is stays as an include. Is this correct this way? Thanks Heiko