From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72FBCC3600C for ; Mon, 31 Mar 2025 13:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HWooIc3os8p0nMskc5BNvunTe8NZcWqXI8Mkie2yYgw=; b=YZD46fgS9ASIasZpGZ1sJ7ZyQP GvKGhLZuUMRxFPnNCqwKt19ArRUVGp2906QG6emax9Gf48g2uLWRIHBOnMctETNEW/duy99ek64Z/ 2JPsp6UJHf2EVW/M9LulKAhKsZlkQLr0jWqMNebORB6RJdHUuWHZp0Uinpqf+33/+RnLZiGyMQdKQ jVLA1CAEVJAUd5Rfiz3rEhKhiO2spmFLfpyVyHbTspYBJnFoia2C6PWxjFCPrxoHuxyNBzcop4TTa xir90rslqasGmtaKer10h0T2Gsj5GHmdZAWiR41EcysJOWs/j50Rh9dhI76KDvEV6sBv1VU6d6J8O KXtfInTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzF9m-00000000RXr-26fU; Mon, 31 Mar 2025 13:26:26 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzF9j-00000000RWj-2LHV; Mon, 31 Mar 2025 13:26:24 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1743427559; cv=none; d=zohomail.com; s=zohoarc; b=lFpzyWNT0USwVhZo90t1H8YsKmXjkTiA40JVXFnWo4QCPAIk2thx7TRBlAU1K8dPThDc1FIFEYAX4FIom3w23pokpTh/x1Mg4e6yP3fzKqbgKWLkiz6TFLxuYaiHAXXHS1mctV24fS+qH0cfeKzobVyKDJR8eZNUgAT0or9iiF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743427559; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=HWooIc3os8p0nMskc5BNvunTe8NZcWqXI8Mkie2yYgw=; b=FyJqWhpbofJ3JePl7TCwFDAJ1r9kM5DiBswVCtsyEncz5aO++A94Lv8x+2b07Y9how9mN2ZYTEzuIXH7sWOFWYsErvYs5Tlozrd39DA4FXoO0K3wrZeyw5MY3OKlUnpeFyi1Rl1LyqK8YwL7wqgRhF+B7m8ykeFtEUCss6ggIWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1743427559; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=HWooIc3os8p0nMskc5BNvunTe8NZcWqXI8Mkie2yYgw=; b=k492Rhoxz+7diXbMUgv1Ut3B3mjToaQHx37PzVyEGSmze1bsEZQIfeJ4NgBDdA2M NL0HbA23ybIE+SErXhBegGTPl66oS60Ti0OBi5XFh9YJ5aK85GWX/ReGY9ALX10OBi5 U/1UtHTusAnM4Mt5ZDDLjk2AT4H/jHxGWhZDasK0= Received: by mx.zohomail.com with SMTPS id 1743427556313451.45814764603153; Mon, 31 Mar 2025 06:25:56 -0700 (PDT) Message-ID: <114525a6-950e-4894-92de-fa7655bb9156@collabora.com> Date: Mon, 31 Mar 2025 10:25:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/6] drm/panfrost: Add support for AARCH64_4K page table format To: Steven Price , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: boris.brezillon@collabora.com, robh@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kernel@collabora.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sjoerd@collabora.com, angelogioacchino.delregno@collabora.com, =?UTF-8?Q?Adri=C3=A1n_Larumbe?= References: <20250324185801.168664-1-ariel.dalessandro@collabora.com> <20250324185801.168664-5-ariel.dalessandro@collabora.com> <2aa3bf07-924b-4359-b566-0db57d53cdf5@arm.com> Content-Language: en-US From: Ariel D'Alessandro In-Reply-To: <2aa3bf07-924b-4359-b566-0db57d53cdf5@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250331_062623_646094_6953464F X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Steven, On 3/31/25 8:15 AM, Steven Price wrote: > On 24/03/2025 18:57, Ariel D'Alessandro wrote: >> Currently, Panfrost only supports MMU configuration in "LEGACY" (as >> Bifrost calls it) mode, a (modified) version of LPAE "Large Physical >> Address Extension", which in Linux we've called "mali_lpae". >> >> This commit adds support for conditionally enabling AARCH64_4K page >> table format. To achieve that, a "GPU optional quirks" field was added >> to `struct panfrost_features` with the related flag. >> >> Note that, in order to enable AARCH64_4K mode, the GPU variant must have >> the HW_FEATURE_AARCH64_MMU feature flag present. >> >> Signed-off-by: Ariel D'Alessandro >> Reviewed-by: AngeloGioacchino Del Regno >> Reviewed-by: Boris Brezillon >> Reviewed-by: Adrián Larumbe > > Reviewed-by: Steven Price > > (one very minor nit below) > >> --- >> drivers/gpu/drm/panfrost/panfrost_device.h | 16 +++ >> drivers/gpu/drm/panfrost/panfrost_mmu.c | 140 +++++++++++++++++++-- >> drivers/gpu/drm/panfrost/panfrost_regs.h | 34 +++++ >> 3 files changed, 183 insertions(+), 7 deletions(-) >> > > [...] > >> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c >> index 294f86b3c25e..ccf51fd5f9c0 100644 >> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c >> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > [...] >> + >> +static int panfrost_mmu_cfg_init(struct panfrost_mmu *mmu, >> + enum io_pgtable_fmt fmt) > > NIT: It's always hard to see in the diff, but the alignment of the > second line is wrong. But I'll fix this up when merging. Indeed, you're right. Thanks for the nitpick! Happy to see this hitting drm-misc-next soon :) -- Ariel D'Alessandro Software Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718