Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Crystal Guo (郭晶)" <Crystal.Guo@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzk@kernel.org" <krzk@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
Date: Tue, 11 Feb 2025 11:25:04 +0000	[thread overview]
Message-ID: <115b6e35d36f0ee9fbf46e5df0be7eaa928d78ad.camel@mediatek.com> (raw)
In-Reply-To: <bdae5678-ff79-4c04-8d77-c6bdfe613c68@kernel.org>

On Sun, 2025-02-09 at 11:48 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 06/02/2025 13:16, Crystal Guo wrote:
> > A MediaTek DRAM controller interface to provide the current DDR
> > data rate.
> 
> Please wrap commit message according to Linux coding style /
> submission
> process (neither too early nor over the limit):
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst*L597__;Iw!!CTRNKA9wMg0ARbw!lrJR1xYY1zrw1dRnvzwOsd0FyqQawTURFAKVFpWEaMLN2eiV03gQy8WDacH-ZGIypB4-WuPupcOERlw9$
> 
> 
> > 
> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> > ---
> >  .../mediatek,common-dramc.yaml                | 129 --------------
> > ----
> 
> Why is there removal here if you add? Commit msg explains nothing
> here.
> 
> Why this patch was sent twice?
> 
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch -vX` helps here to create proper versioned
> patches. Another useful tool is b4. Skipping the PATCH keyword makes
> filtering of emails more difficult thus making the review process
> less
> convenient.
> 
> Best regards,
> Krzysztof

This patch was based on the previous version.
But the approach was actually incorrect (shall NOT be patches on the
top of the previous version), so I have resent the new v2 patches based
on a clean kernel.

Thanks
Crystal


  reply	other threads:[~2025-02-11 11:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 12:16 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-06 12:16 ` [v2,1/2] memory/mediatek: " Crystal Guo
2025-02-06 12:31   ` AngeloGioacchino Del Regno
2025-02-07  1:30     ` Crystal Guo (郭晶)
2025-02-09 10:51   ` Krzysztof Kozlowski
2025-02-06 12:16 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:48   ` Krzysztof Kozlowski
2025-02-11 11:25     ` Crystal Guo (郭晶) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-07  1:42 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-07  1:42 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:51   ` Krzysztof Kozlowski
2025-02-12  3:50     ` Crystal Guo (郭晶)
2025-02-12  5:34       ` Krzysztof Kozlowski
2025-02-12 10:07         ` Crystal Guo (郭晶)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=115b6e35d36f0ee9fbf46e5df0be7eaa928d78ad.camel@mediatek.com \
    --to=crystal.guo@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox