Re: [PATCH net-next 3/3] net: phy: mediatek: support EcoNet EN751221 gbit SoC PHY

[Caleb James DeLisle <cjd@cjdns.fr>]

On 26/08/2026 18:50, Andrew Lunn wrote:
>> I tested my board removing the EEE disable and the MASTER line, and it seems
>> to work. I can't get any CRC errors flooding the link, and MII_STAT1000
>> reads LPA_1000LOCALRXOK | LPA_1000REMRXOK | LPA_1000FULL which suggests to
>> me that it's able to operate happily in slave mode.
>>
>>
>> So unless you or someone else thinks it's inadvisable, I'm inclined to just
>> enable these things and then wait to see if anybody finds a board that has
>> problems.
> Master/slave should sort itself out, maybe taking a little longer if
> there is an initial conflict. Where it can go wrong is when the random
> number generator in the PHY always returns 42. Put the same PHY on the
> other end and the election always fails.
>
> EEE issues can be more subtle, it depends on what the link partner is.
>
> But yes, we can start without these. But please mention this in the
> commit message, just to give a hint to anybody who ends up trying to
> debug in these areas.


Just re-sent v2, in fact after this conversation I did more testing and 
caught it sporadically failing to negotiate, so I put back the force 
master, confirmed it is fixed, and added a comment.

Thanks again for your kind review and advice.

Caleb


>
>        Andrew