From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henry Chen Subject: Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator Date: Fri, 24 Jul 2015 20:59:58 +0800 Message-ID: <1437742798.30329.100.camel@mtksdaap41> References: <1437715481-31528-1-git-send-email-henryc.chen@mediatek.com> <1437715481-31528-2-git-send-email-henryc.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Mark Brown , Mark Rutland , Liam Girdwood , Linux Kernel , linux-mediatek@lists.infradead.org, Sascha Hauer , Matthias Brugger , eddie.huang@mediatek.com, "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org Hi Javier, On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote: > Hello Henry, > > I believe Mark asked you to use a subject lines reflecting the style > for the subsystem, so the subject should had been something like: > > regulators: mt6311: Add DT binding document > > On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen wrote: > > This patch adds a list of supported regulator names to the devicetree > > binding documentation for Mediatek MT6311 PMIC. > > > > Signed-off-by: Henry Chen > > --- > > I know is in your cover letter, but usually is good to also include a > history log of the changes for each patch so people know what changed. > Everything between the '---' and the diff are omitted by tools like > git am so you can add there. You can use tools like patman that do > this automatically for you. > Ok, got it, I will follow that. > Also, I said that you could add my Reviewed-by after the node name > change so you should had carried that. So again: Sorry, did you mean I need to resent again? Thanks for advise. Henry > Reviewed-by: Javier Martinez Canillas > > Best regards, > Javier