From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [RFC v4 05/11] dt-bindings: drm/mediatek: Add Mediatek HDMI dts binding Date: Wed, 28 Oct 2015 18:50:23 +0100 Message-ID: <1446054623.7190.5.camel@pengutronix.de> References: <1445026333-17013-1-git-send-email-p.zabel@pengutronix.de> <1445026333-17013-6-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: dri-devel , Daniel Vetter , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Dave Airlie , Matthias Brugger , Cawa Cheng , CK Hu , YT Shen , Jitao Shi , Jie Qiu , Paul Bolle , Daniel Stone , Daniel Kurtz , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" List-Id: linux-mediatek@lists.infradead.org Hi Rob, thank you for the comments. Am Freitag, den 23.10.2015, 07:29 -0500 schrieb Rob Herring: [...] > > +Mediatek HDMI Encoder > > +===================== > > + > > +The Mediatek HDMI encoder can generate HDMI 1.4a or MHL 2.0 signals from > > +its parallel input. > > How do you know whether it is HDMI or MHL on a given board? You should > have a connector node perhaps. Sounds sensible. I haven't really thought about MHL, my test board has a slimport bridge. For HDMI we already have the "hdmi-connector" compatible. I suppose for MHL we'd have to add a new "usb-connector"? > > + > > +Required properties: > > +- compatible: Should be "mediatek,-hdmi". > > +- reg: Physical base address and length of the controller's registers > > +- interrupts: The interrupt signal from the function block. > > +- clocks: device clocks > > + See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > > +- clock-names: must contain "pixel", "pll", "bclk", and "spdif". > > +- mediatek,cec: phandle link to the HDMI CEC node. > > Do you have more than 1 CEC block? If not, just find the compatible > node with of_find_compatible_node. MT8173 only has one CEC block, so I will drop this property again. > > +- ddc-i2c-bus: phandle link to the I2C controller used for DDC EDID probing > > This really should be part of a connector node as I2C bus goes to the > connector, not the HDMI block. So I should add that as an optional property to the hdmi-connector binding. I'll have to check how DDC is handled for MHL. [...] > > +HDMI PHY > > +======== > > + > > +The HDMI PHY serializes the HDMI encoder's three channel 10-bit parallel > > +output and drives the HDMI pads. > > + > > +Required properties: [...] > > + > > +Optional properties: > > +- ibias: TX DRV bias current for <1.65Gbps, defaults to 0xa > > +- ibias_up: TX DRV bias current for >1.65Gbps, defaults to 0x1c > > prefix with "mediatek," Will do. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html