From: Hongzhou Yang <hongzhou.yang@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Hongzhou Yang <hongzhou.yang@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Axel Lin <axel.lin@ingics.com>,
Maoguang Meng <maoguang.meng@mediatek.com>,
Colin Ian King <colin.king@canonical.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
biao.huang@mediatek.com
Subject: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps.
Date: Mon, 16 Nov 2015 18:34:50 -0800 [thread overview]
Message-ID: <1447727690-15251-1-git-send-email-hongzhou.yang@mediatek.com> (raw)
configs will kmemdup to dup_configs in pictrl util function.
So configs need to be freed.
Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
---
Fix a memleak issue.
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index bbf0230..0000b5a 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -568,9 +568,10 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
}
}
- return 0;
+ err = 0;
fail:
+ kfree(configs);
return err;
}
--
1.7.9.5
next reply other threads:[~2015-11-17 2:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 2:34 Hongzhou Yang [this message]
2015-11-17 2:50 ` [PATCH] pinctrl: mediatek: fix a memleak when do dt maps Daniel Kurtz
-- strict thread matches above, loose matches on Subject: below --
2015-11-17 4:22 Hongzhou Yang
2015-11-17 8:25 ` Daniel Kurtz
2015-11-17 10:50 ` Matthias Brugger
2015-11-17 14:18 ` Yingjoe Chen
2015-11-17 22:33 Hongzhou Yang
2015-11-18 3:22 ` Yingjoe Chen
2015-11-29 21:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447727690-15251-1-git-send-email-hongzhou.yang@mediatek.com \
--to=hongzhou.yang@mediatek.com \
--cc=axel.lin@ingics.com \
--cc=biao.huang@mediatek.com \
--cc=colin.king@canonical.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox