public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Henry Chen <henryc.chen@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: linux-mediatek@lists.infradead.org, eddie.huang@mediatek.com,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
	<linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] regulator: mt6311: Use REGCACHE_RBTREE
Date: Fri, 18 Dec 2015 15:34:22 +0800	[thread overview]
Message-ID: <1450424062.12852.3.camel@mtksdaap41> (raw)
In-Reply-To: <1450422693-371-1-git-send-email-djkurtz@chromium.org>

Thanks to the patch.

On Fri, 2015-12-18 at 15:11 +0800, Daniel Kurtz wrote:
> This regulator is on a slow i2c bus.  Register accesses are very simple,
> they all either enable/disable a regulator channel, or select a new
> voltage level.  Thus, reading registers from the device will always
> return what was last written.
> 
> Therefore we can save a lot of time when reading registers by using a
> regmap_cache.  Since the register map is relatively large, but we only
> ever access a few of them, we use an RBTREE cache.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

Acked-by: Henry Chen <henryc.chen@mediatek.com>

> ---
> I used the wrong commit message subject in the first attempt.
> Maybe this time someone will review it ;-).
> ---
>  drivers/regulator/mt6311-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/mt6311-regulator.c b/drivers/regulator/mt6311-regulator.c
> index 02c4e5f..0495716 100644
> --- a/drivers/regulator/mt6311-regulator.c
> +++ b/drivers/regulator/mt6311-regulator.c
> @@ -30,6 +30,7 @@ static const struct regmap_config mt6311_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.max_register = MT6311_FQMTR_CON4,
> +	.cache_type = REGCACHE_RBTREE,
>  };
>  
>  /* Default limits measured in millivolts and milliamps */

      reply	other threads:[~2015-12-18  7:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  7:11 [RESEND PATCH] regulator: mt6311: Use REGCACHE_RBTREE Daniel Kurtz
2015-12-18  7:34 ` Henry Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450424062.12852.3.camel@mtksdaap41 \
    --to=henryc.chen@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=eddie.huang@mediatek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox