From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-mediatek@lists.infradead.org,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: mt6397: Add platform device ID table
Date: Tue, 9 Feb 2016 08:08:14 -0300 [thread overview]
Message-ID: <1455016095-13724-1-git-send-email-javier@osg.samsung.com> (raw)
The platform bus_type .match callback attempts to match the platform device
name with an entry on the .id_table if provided and fallbacks to match with
the driver's name if a table is not provided.
Using a platform device ID to match is more explicit, allows the driver to
support more than one device and also the MODULE_DEVICE_TABLE macro can be
used to export the module aliases information instead of the MODULE_ALIAS.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/rtc/rtc-mt6397.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 06a5c52b292f..46533f11f7fc 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -404,6 +404,12 @@ static const struct of_device_id mt6397_rtc_of_match[] = {
};
MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match);
+static const struct platform_device_id mt6397_rtc_id[] = {
+ {"mt6397-rtc", 0},
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(platform, mt6397_rtc_id);
+
static struct platform_driver mtk_rtc_driver = {
.driver = {
.name = "mt6397-rtc",
@@ -412,6 +418,7 @@ static struct platform_driver mtk_rtc_driver = {
},
.probe = mtk_rtc_probe,
.remove = mtk_rtc_remove,
+ .id_table = mt6397_rtc_id,
};
module_platform_driver(mtk_rtc_driver);
@@ -419,4 +426,3 @@ module_platform_driver(mtk_rtc_driver);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Tianping Fang <tianping.fang@mediatek.com>");
MODULE_DESCRIPTION("RTC Driver for MediaTek MT6397 PMIC");
-MODULE_ALIAS("platform:mt6397-rtc");
--
2.5.0
next reply other threads:[~2016-02-09 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 11:08 Javier Martinez Canillas [this message]
2016-02-15 1:58 ` [PATCH] rtc: mt6397: Add platform device ID table Eddie Huang
2016-02-15 14:50 ` Javier Martinez Canillas
[not found] ` <56C1E5C8.6040007-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-16 11:37 ` Arnd Bergmann
2016-02-16 13:19 ` Eddie Huang
2016-02-24 16:56 ` Arnd Bergmann
2016-02-24 17:02 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455016095-13724-1-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=eddie.huang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox