From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wu Subject: Re: [PATCH] iommu/mtk: fix handling of of_count_phandle_with_args result Date: Wed, 2 Mar 2016 02:19:49 +0800 Message-ID: <1456856389.26149.4.camel@mhfsdcap03> References: <1456824983-13550-1-git-send-email-a.hajda@samsung.com> <20160301113447.GO22747@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160301113447.GO22747-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel , Andrzej Hajda Cc: Matthias Brugger , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Bartlomiej Zolnierkiewicz List-Id: linux-mediatek@lists.infradead.org On Tue, 2016-03-01 at 12:34 +0100, Joerg Roedel wrote: > On Tue, Mar 01, 2016 at 10:36:23AM +0100, Andrzej Hajda wrote: > > The function can return negative value so it should be assigned to signed > > variable. The patch changes also type of related i variable to make code > > more compact and coherent. > > > > The problem has been detected using patch > > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. > > > > Signed-off-by: Andrzej Hajda > > --- > > drivers/iommu/mtk_iommu.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Applied, thanks. Thanks. nit: It would be better to use iommu/mediatek. > > _______________________________________________ > iommu mailing list > iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu