* [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
@ 2016-09-20 8:30 Arvind Yadav
2016-09-21 3:29 ` James Liao
2016-09-21 18:47 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2016-09-20 8:30 UTC (permalink / raw)
To: mturquette, sboyd, matthias.bgg
Cc: jamesjj.liao, djkurtz, p.zabel, yingjoe.chen, linux-clk,
linux-kernel, linux-arm-kernel, linux-mediatek, Arvind Yadav
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Free memory mapping, if init is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clk/mediatek/clk-mt8173.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
index 10c9860..0ac3aee 100644
--- a/drivers/clk/mediatek/clk-mt8173.c
+++ b/drivers/clk/mediatek/clk-mt8173.c
@@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
}
mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
- if (!clk_data)
+ if (!clk_data) {
+ iounmap(base);
return;
+ }
mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
2016-09-20 8:30 [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap Arvind Yadav
@ 2016-09-21 3:29 ` James Liao
2016-09-21 18:47 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: James Liao @ 2016-09-21 3:29 UTC (permalink / raw)
To: Arvind Yadav
Cc: mturquette, sboyd, matthias.bgg, djkurtz, p.zabel, yingjoe.chen,
linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek
On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Free memory mapping, if init is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: James Liao <jamesjj.liao@mediatek.com>
> ---
> drivers/clk/mediatek/clk-mt8173.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 10c9860..0ac3aee 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
> }
>
> mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> - if (!clk_data)
> + if (!clk_data) {
> + iounmap(base);
> return;
> + }
>
> mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
2016-09-20 8:30 [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap Arvind Yadav
2016-09-21 3:29 ` James Liao
@ 2016-09-21 18:47 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-09-21 18:47 UTC (permalink / raw)
To: Arvind Yadav
Cc: mturquette, matthias.bgg, jamesjj.liao, djkurtz, p.zabel,
yingjoe.chen, linux-clk, linux-kernel, linux-arm-kernel,
linux-mediatek
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Free memory mapping, if init is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-21 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-20 8:30 [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap Arvind Yadav
2016-09-21 3:29 ` James Liao
2016-09-21 18:47 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).