Re: [PATCH] clk: mediatek: Fix MT2701 dependencies

Jean Delvare
2017-01-11T14:42:20Z

Hi Joe,

On Wed, 11 Jan 2017 22:05:26 +0800, Yingjoe Chen wrote:
> On Wed, 2017-01-11 at 13:41 +0100, Jean Delvare wrote:
> > @@ -52,16 +52,16 @@ config COMMON_CLK_MT2701_BDPSYS
> >
> > config COMMON_CLK_MT8135
> > bool "Clock driver for Mediatek MT8135"
> > - depends on ARCH_MEDIATEK || COMPILE_TEST
> > + depends on (ARCH_MEDIATEK && !ARM64) || COMPILE_TEST
>
>
> Why not just check for ARM?
>
> + depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST

I don't know :D Andreas suggested it for MT2701, so I assumed ARM was
set also for 64-bit kernels (like X86 is set for 64-bit kernels) and
ARM64 had to be used to differentiate. But it seems ARM isn't set for
64-bit kernels, so you are right, checking for ARM should work and is
more straightforward. I'll fix it before submitting the patch.

Thanks for the review,