From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands
Date: Fri, 24 Mar 2017 14:19:00 +0800 [thread overview]
Message-ID: <1490336341-22292-2-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1490336341-22292-1-git-send-email-chaotian.jing@mediatek.com>
this patch is refine for 'commit c6dbab9cb58f ("mmc: core: Hold re-tuning
during switch commands")'
Since it has 3 retries at max for CMD6, if the first CMD6 got CRC error,
then should do re-tune before the next CMD6 was sent.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/core/mmc_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index fe80f26..6931927 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -534,8 +534,6 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
bool use_r1b_resp = use_busy_signal;
unsigned char old_timing = host->ios.timing;
- mmc_retune_hold(host);
-
/*
* If the cmd timeout and the max_busy_timeout of the host are both
* specified, let's validate them. A failure means we need to prevent
@@ -567,6 +565,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
cmd.sanitize_busy = true;
err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+ mmc_retune_hold(host);
if (err)
goto out;
--
1.7.9.5
next prev parent reply other threads:[~2017-03-24 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 6:18 mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing
2017-03-24 6:19 ` Chaotian Jing [this message]
2017-03-24 7:52 ` [PATCH] " Adrian Hunter
2017-03-24 8:32 ` Chaotian Jing
2017-03-24 9:19 ` Adrian Hunter
2017-03-24 9:40 ` Chaotian Jing
2017-03-24 10:49 ` Ulf Hansson
2017-03-27 1:35 ` Chaotian Jing
2017-03-28 8:30 ` Ulf Hansson
2017-03-28 9:01 ` Adrian Hunter
2017-03-28 9:58 ` Ulf Hansson
2017-03-28 9:59 ` Ulf Hansson
2017-03-29 2:27 ` Chaotian Jing
2017-03-28 9:59 ` Chaotian Jing
2017-03-29 10:33 ` Ulf Hansson
2017-03-29 10:36 ` Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490336341-22292-2-git-send-email-chaotian.jing@mediatek.com \
--to=chaotian.jing@mediatek.com \
--cc=adrian.hunter@intel.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=shawn.lin@rock-chips.com \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox