From mboxrd@z Thu Jan 1 00:00:00 1970 From: chen.zhong Subject: Re: [PATCH] soc: mtk-pmic-wrap: make of_device_ids const. Date: Wed, 28 Jun 2017 20:10:06 +0800 Message-ID: <1498651806.6668.2.camel@mhfsdcap03> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Arvind Yadav Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Hi, On Wed, 2017-06-28 at 10:28 +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index a5f1093..1205a671 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1067,7 +1067,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) > .init_soc_specific = pwrap_mt2701_init_soc_specific, > }; > > -static struct pmic_wrapper_type pwrap_mt8135 = { > +static const struct pmic_wrapper_type pwrap_mt8135 = { > .regs = mt8135_regs, > .type = PWRAP_MT8135, > .arb_en_all = 0x1ff, > @@ -1079,7 +1079,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) > .init_soc_specific = pwrap_mt8135_init_soc_specific, > }; > > -static struct pmic_wrapper_type pwrap_mt8173 = { > +static const struct pmic_wrapper_type pwrap_mt8173 = { > .regs = mt8173_regs, > .type = PWRAP_MT8173, > .arb_en_all = 0x3f, > @@ -1091,7 +1091,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) > .init_soc_specific = pwrap_mt8173_init_soc_specific, > }; > > -static struct of_device_id of_pwrap_match_tbl[] = { > +static const struct of_device_id of_pwrap_match_tbl[] = { > { > .compatible = "mediatek,mt2701-pwrap", > .data = &pwrap_mt2701, Acked-by: Chen Zhong