From: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Garlic Tseng
<garlic.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] ASoC: mediatek: Correct the interrupt property
Date: Tue, 15 Aug 2017 21:51:40 +0800 [thread overview]
Message-ID: <1502805100.25910.8.camel@mtkswgap22> (raw)
In-Reply-To: <20170815115309.glj52jx3kpq4jxq3-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote:
> On Tue, Aug 15, 2017 at 04:07:02PM +0800, Ryder Lee wrote:
>
> > This patch update interrupt property since we only use ASYS IRQ
> > in the driver, and this may confuse people.
>
> > - interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_LOW>,
> > - <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
> > + interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
>
> What harm does having the extra information in the bindings do? If it's
> possible there might be a use for the extra interrupt it seems better to
> have people describe it.
Yes you're right. The current driver get IRQ number by index "0" but
actually it should be "1" (GIC 132). Perhaps we can switch to use the
platform_get_irq_byname() and add interrupt-name in DT so that binding
can be agnostic of the IRQ order.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-15 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 8:07 [PATCH] ASoC: mediatek: Correct the interrupt property Ryder Lee
2017-08-15 11:53 ` Mark Brown
[not found] ` <20170815115309.glj52jx3kpq4jxq3-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-08-15 13:51 ` Ryder Lee [this message]
2017-08-15 13:56 ` Mark Brown
2017-08-17 21:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502805100.25910.8.camel@mtkswgap22 \
--to=ryder.lee-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=garlic.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox