Re: [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node.

Zhiyong Tao
2017-09-22T01:31:34Z

On Thu, 2017-09-21 at 14:17 +0200, Linus Walleij wrote:
> On Thu, Sep 21, 2017 at 10:13 AM, Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> > On Tue, 2017-08-22 at 15:04 +0200, Linus Walleij wrote:
> >> On Mon, Aug 14, 2017 at 5:23 PM, Matthias Brugger
> >> <matthias.bgg@gmail.com> wrote:
> >> > On 07/31/2017 10:22 AM, Zhiyong Tao wrote:
> >> >>
> >> >> The commit includes two change:
> >> >> 1)add pintcrl device node for mt2712.
> >> >> 2)add pinfunc file for mt2712.
> >> >>
> >> >> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> >> >> ---
> >> >> arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1014
> >> >> +++++++++++++++++++++++++
> >> >
> >> >
> >> > Shouldn't this file be in include/dt-bindings/pinctrl?
> >>
> >> Only if it is also #included in the driver.
> >>
> >> Yours,
> >> Linus Walleij
> >
> > ==>
> > Thanks for your comment.
> > We see our some ICs(mt7623) which move the file to
> > "include/dt-bindings/pinctrl". other ICs(mt2701) which is put in
> > "arch/arm64/boot/dts/mediatek".
> > In mt2712, mt2712-pinfunc.h is only include by dts file. It won't be
> > included by driver. So which is better? "arch/arm64/boot/dts/mediatek/"
> > or "include/dt-bindings/pinctrl".
>
> If it is used in both arm and arm64 it is helpful to have it in
> include/dt-bindings so it can be shared between the two
> archs.
>
> If it is just (ever) for arm64 it can stay inside the arch tree.
>
> Yours,
> Linus Walleij

==> Thanks for your comment. mt2712-pinfunc.h is only used in arm64. so
it can stay inside the arch tree.