From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error Date: Sun, 22 Oct 2017 12:23:11 +0800 Message-ID: <1508646191.29850.23.camel@mtkswgap22> References: <20171021082529.31351-1-matthias.bgg@gmail.com> <20171021082529.31351-2-matthias.bgg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171021082529.31351-2-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matthias Brugger Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org, arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: > When adding the MT6380 compatible, the sentinel for of_device_id was > deleted, which leades to the following compiler error: > FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! > > Fix this by adding the sentinel again. > > Signed-off-by: Matthias Brugger > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 912edf93c192..e9e054a15b7d 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { > }, { > .compatible = "mediatek,mt6397", > .data = &pmic_mt6397, > + }, { > /* sentinel */ > } > }; Thanks for patching the mistaken edit I made. Acked-by: Sean Wang