Re: [PATCH] ASoC: mt6797: switch to SPDX license tag

Mark Brown
2018-04-26T11:42:44Z

[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]

On Thu, Apr 26, 2018 at 12:46:54PM +0200, Matthias Brugger wrote:
> On 04/26/2018 04:56 AM, KaiChieh Chuang wrote:
> > diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > index d42a9d9fbf3e..c3f58bac0960 100644
> > --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > @@ -1,17 +1,9 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
> > *

Please convert the entire header block to a C++ comment so it looks more
intentional that it's this way.

> > - * Author: Ryder Lee <ryder.lee@mediatek.com>
> > + * Author: KaiChieh Chuang <kaichieh.chuang@mediatek.com>

> I think you don't want to delete the first author but add you as a second one.
> I've seen this in other parts of the patch as well. Please check.

Yeah, looks like an over eager removal of the license text boiler
plate.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]