Re: [PATCH] ASoC: mt6797: switch to SPDX license tag

Ryder Lee
2018-04-27T01:56:24Z

On Thu, 2018-04-26 at 12:42 +0100, Mark Brown wrote:
> On Thu, Apr 26, 2018 at 12:46:54PM +0200, Matthias Brugger wrote:
> > On 04/26/2018 04:56 AM, KaiChieh Chuang wrote:
> > > diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > index d42a9d9fbf3e..c3f58bac0960 100644
> > > --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > @@ -1,17 +1,9 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /*
> > > * mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
> > > *
>
> Please convert the entire header block to a C++ comment so it looks more
> intentional that it's this way.
>
> > > - * Author: Ryder Lee <ryder.lee@mediatek.com>
> > > + * Author: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
>
> > I think you don't want to delete the first author but add you as a second one.
> > I've seen this in other parts of the patch as well. Please check.
>
> Yeah, looks like an over eager removal of the license text boiler
> plate.

Fine with me. I think this is a copy+paste mistake as I didn't get
involved in MT6797 before.