From: Sean Wang <sean.wang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: alsa-devel@alsa-project.org, ryder.lee@mediatek.com,
chipeng.chang@mediatek.com, wsd_upstream@mediatek.com,
garlic.tseng@mediatek.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org,
KaiChieh Chuang <kaichieh.chuang@mediatek.com>
Subject: Re: [PATCH v2 1/2] ASoC: mt6797: switch to SPDX license tag
Date: Fri, 27 Apr 2018 17:28:15 +0800 [thread overview]
Message-ID: <1524821295.12322.210.camel@mtkswgap22> (raw)
In-Reply-To: <1524821008.12322.208.camel@mtkswgap22>
On Fri, 2018-04-27 at 17:23 +0800, Sean Wang wrote:
> Ryder and Garlic are not actual authors.
>
> There are totally copy-n-paste errors on Author fields when KaiChieh is
> making the 1st version.
>
> also can see
>
> http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013036.html
>
> http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013036.html
>
Correct double link posted, they should be
http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013035.html
http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013036.html
>
> On Fri, 2018-04-27 at 11:15 +0200, Matthias Brugger wrote:
> >
> > On 04/27/2018 03:54 AM, KaiChieh Chuang wrote:
> > > Signed-off-by: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
> > > ---
> > > sound/soc/mediatek/mt6797/Makefile | 13 +------------
> > > sound/soc/mediatek/mt6797/mt6797-afe-clk.c | 21 ++++++---------------
> > > sound/soc/mediatek/mt6797/mt6797-afe-clk.h | 10 +---------
> > > sound/soc/mediatek/mt6797/mt6797-afe-common.h | 10 +---------
> > > sound/soc/mediatek/mt6797/mt6797-afe-pcm.c | 21 ++++++---------------
> > > sound/soc/mediatek/mt6797/mt6797-interconnection.h | 10 +---------
> > > sound/soc/mediatek/mt6797/mt6797-mt6351.c | 21 ++++++---------------
> > > sound/soc/mediatek/mt6797/mt6797-reg.h | 12 ++----------
> > > 8 files changed, 24 insertions(+), 94 deletions(-)
> > >
> >
> > [...]
> >
> > > diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > index d42a9d9fbf3e..9e5866d6819a 100644
> > > --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > > @@ -1,18 +1,9 @@
> > > -/*
> > > - * mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
> > > - *
> > > - * Copyright (c) 2018 MediaTek Inc.
> > > - * Author: Ryder Lee <ryder.lee@mediatek.com>
> > > - *
> > > - * This program is free software; you can redistribute it and/or modify
> > > - * it under the terms of the GNU General Public License version 2 and
> > > - * only version 2 as published by the Free Software Foundation.
> > > - *
> > > - * This program is distributed in the hope that it will be useful,
> > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > > - * GNU General Public License for more details.
> > > - */
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +//
> > > +// mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
> > > +//
> > > +// Copyright (c) 2018 MediaTek Inc.
> > > +// Author: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
> >
> > As we said in the last version, you should not delete Ryder from the author list.
> >
> > >
> > > #include <linux/module.h>
> > > #include <sound/soc.h>
> > > diff --git a/sound/soc/mediatek/mt6797/mt6797-reg.h b/sound/soc/mediatek/mt6797/mt6797-reg.h
> > > index 3330f73fc8bb..ffb55367f59f 100644
> > > --- a/sound/soc/mediatek/mt6797/mt6797-reg.h
> > > +++ b/sound/soc/mediatek/mt6797/mt6797-reg.h
> > > @@ -1,17 +1,9 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > /*
> > > * mt6797-reg.h -- Mediatek 6797 audio driver reg definition
> > > *
> > > * Copyright (c) 2018 MediaTek Inc.
> > > - * Author: Garlic Tseng <garlic.tseng@mediatek.com>
> > > - *
> > > - * This program is free software; you can redistribute it and/or modify
> > > - * it under the terms of the GNU General Public License version 2 and
> > > - * only version 2 as published by the Free Software Foundation.
> > > - *
> > > - * This program is distributed in the hope that it will be useful,
> > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > > - * GNU General Public License for more details.
> > > + * Author: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
> >
> > Same here, Garlic is an author as well, don't delete him from the comment.
> >
> > Regards,
> > Matthias
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
next prev parent reply other threads:[~2018-04-27 9:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 1:54 [PATCH v2 0/2] ASoC: mt6797-mt6351: switch to SPDX license tag KaiChieh Chuang
[not found] ` <20180427015445.4334-1-kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-04-27 1:54 ` [PATCH v2 1/2] ASoC: mt6797: " KaiChieh Chuang
2018-04-27 9:15 ` Matthias Brugger
2018-04-27 9:23 ` Sean Wang
2018-04-27 9:27 ` Matthias Brugger
2018-04-27 9:28 ` Sean Wang [this message]
2018-04-27 10:41 ` Mark Brown
2018-04-27 10:55 ` Mark Brown
2018-04-27 10:53 ` Applied "ASoC: mt6797: switch to SPDX license tag" to the asoc tree Mark Brown
2018-04-27 1:54 ` [PATCH v2 2/2] ASoC: mt6351 switch to SPDX license tag KaiChieh Chuang
[not found] ` <20180427015445.4334-3-kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-04-27 10:53 ` Applied "ASoC: mt6351 switch to SPDX license tag" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524821295.12322.210.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chipeng.chang@mediatek.com \
--cc=garlic.tseng@mediatek.com \
--cc=kaichieh.chuang@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox