From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miles Chen Subject: Re: [PATCH] arm64: kaslr: print PHYS_OFFSET in dump_kernel_offset() Date: Fri, 14 Dec 2018 08:52:36 +0800 Message-ID: <1544748756.29110.2.camel@mtkswgap22> References: <1544612209-13660-1-git-send-email-miles.chen@mediatek.com> <20181213181317.GD18185@edgewater-inn.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Matthias Brugger , linux-arm-kernel , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , wsd_upstream@mediatek.com List-Id: linux-mediatek@lists.infradead.org On Thu, 2018-12-13 at 19:15 +0100, Ard Biesheuvel wrote: > On Thu, 13 Dec 2018 at 19:12, Will Deacon wrote: > > > > [+Ard because I'll basically go with his preference on this one] > > > > On Wed, Dec 12, 2018 at 06:56:49PM +0800, Miles Chen wrote: > > > When debug with kaslr, it is sometimes necessary to have PHYS_OFFSET to > > > perform linear virtual address to physical address translation. > > > Sometimes we're debugging with only few information such as a kernel log > > > and a symbol file, print PHYS_OFFSET in dump_kernel_offset() for that case. > > > > > > Tested by: > > > echo c > /proc/sysrq-trigger > > > [ 11.996161] SMP: stopping secondary CPUs > > > [ 11.996732] Kernel Offset: 0x2522200000 from 0xffffff8008000000 > > > [ 11.996881] PHYS_OFFSET: 0xffffffeb40000000 > > > > > > Signed-off-by: Miles Chen > > > Tested-by: Miles Chen > > Fine with me, but I would like to see an ack from Miles Chen :-) Can I ack my own patch? Acked-by:Miles Chen > > > > --- > > > arch/arm64/kernel/setup.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > > index f4fc1e0544b7..4b0e1231625c 100644 > > > --- a/arch/arm64/kernel/setup.c > > > +++ b/arch/arm64/kernel/setup.c > > > @@ -388,6 +388,7 @@ static int dump_kernel_offset(struct notifier_block *self, unsigned long v, > > > if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && offset > 0) { > > > pr_emerg("Kernel Offset: 0x%lx from 0x%lx\n", > > > offset, KIMAGE_VADDR); > > > + pr_emerg("PHYS_OFFSET: 0x%llx\n", PHYS_OFFSET); > > > } else { > > > pr_emerg("Kernel Offset: disabled\n"); > > > } > > > -- > > > 2.18.0 > > >