From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanley Chu Subject: Re: [PATCH v1 1/1] scsi: ufs: Fix system suspend status Date: Thu, 10 Jan 2019 11:13:12 +0800 Message-ID: <1547089992.2596.3.camel@mtkswgap22> References: <1546870774-19691-1-git-send-email-stanley.chu@mediatek.com> <1546870774-19691-3-git-send-email-stanley.chu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1546870774-19691-3-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vinholikatti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, avri.altman-Sjgp3cTcYWE@public.gmane.org Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kuohong.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, peter.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, wsd_upstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org (Add missing maintainers/reviewers) Hi Vinayak, Avri, What would you think about the simple patch as below ? Regards. Thanks. On Mon, 2019-01-07 at 22:19 +0800, stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Stanley Chu > > hba->is_sys_suspended is set after successful system suspend but > not clear after successful system resume. > > According to current behavior, hba->is_sys_suspended will not > be set if host is runtime-suspended but not system-suspended. Thus > we shall aligh the same policy: clear this flag even if host remains > runtime-suspended after ufshcd_system_resume is successfully returned. > > Simply fix this flag to correct host status logs. > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 23d7cca..17536bd 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -7916,6 +7916,8 @@ int ufshcd_system_resume(struct ufs_hba *hba) > trace_ufshcd_system_resume(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > hba->curr_dev_pwr_mode, hba->uic_link_state); > + if (!ret) > + hba->is_sys_suspended = false; > return ret; > } > EXPORT_SYMBOL(ufshcd_system_resume);