Re: [PATCH v1 2/5] dt-bindings: pwm: add a property "mediatek,num-pwms"

Rob Herring
2019-02-18T20:36:58Z

On Fri, Jan 18, 2019 at 09:44:49AM +0100, Matthias Brugger wrote:
>
>
> On 18/01/2019 04:24, Ryder Lee wrote:
> > This adds a property "mediatek,num-pwms" in example so that we could
> > set the number of PWM channels via device tree.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > ---
> > Changes since v1: add a Reviewed-by tag.
> > ---
> > Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > index 991728c..f9e2d1f 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > @@ -20,6 +20,7 @@ Required properties:
> > - pinctrl-names: Must contain a "default" entry.
> > - pinctrl-0: One property must exist for each entry in pinctrl-names.
> > See pinctrl/pinctrl-bindings.txt for details of the property values.
> > + - mediatek,num-pwms: the number of PWM channels.
> >
> > Example:
> > pwm0: pwm@11006000 {
> > @@ -37,4 +38,5 @@ Example:
> > "pwm3", "pwm4", "pwm5";
> > pinctrl-names = "default";
> > pinctrl-0 = <&pwm0_pins>;
> > + mediatek,num-pwms = <5>;
> > };
> >
>
> Wasn't there a comment in the last version to use num-pwms instead of
> mediatek,num-pwms?
>
> Uwe I think you requested that.

Perhaps, but why is this needed? Typically, this would be implied by the
compatible or the driver doesn't care and we assume 'pwms' properties
are not out of range.

Rob