From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Simon Horman <horms+renesas@verge.net.au>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Kyle Roeschley <kyle.roeschley@ni.com>,
Hongjie Fang <hongjiefang@asrmicro.com>,
Harish Jenny K N <harish_kandiga@mentor.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH v1] mmc: mmc: Fix HS setting in mmc_hs400_to_hs200()
Date: Wed, 13 Feb 2019 17:06:52 +0800 [thread overview]
Message-ID: <1550048812-29068-1-git-send-email-chaotian.jing@mediatek.com> (raw)
mmc_hs400_to_hs200() begins with the card and host in HS400 mode.
Therefore, any commands sent to the card should use HS400 timing.
reduce clock frequency to 50Mhz but without host timming change
may cause CMD6 response CRC error. because host still running at
hs400 mode, and it's hard to find a suitable setting for all eMMC
cards when clock frequency reduced to 50Mhz but card & host still
in hs400 mode.
this patch refers to mmc_select_hs400(), make the reduce clock frequency
after card timing change.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Fixes: ef3d232245ab ("mmc: mmc: Relax checking for switch errors after HS200 switch")
---
drivers/mmc/core/mmc.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 09c688f..00adc2d 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1239,20 +1239,37 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
int err;
u8 val;
- /* Reduce frequency to HS */
- max_dtr = card->ext_csd.hs_max_dtr;
- mmc_set_clock(host, max_dtr);
-
/* Switch HS400 to HS DDR */
val = EXT_CSD_TIMING_HS;
err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_HS_TIMING,
val, card->ext_csd.generic_cmd6_time, 0,
true, false, true);
- if (err)
- goto out_err;
+ /*
+ * as we are on the way to do re-tune, so if the CMD6 got response CRC
+ * error, do not treat it as error.
+ */
+ if (err) {
+ if (err == -EILSEQ) {
+ /*
+ * card will busy after sending out response and host
+ * driver may not wait busy de-assert when get
+ * response CRC error. so just wait enough time to
+ * ensure card leave busy state.
+ */
+ mmc_delay(card->ext_csd.generic_cmd6_time);
+ pr_debug("%s: %s switch to HS got CRC error\n",
+ mmc_hostname(host), __func__);
+ } else {
+ goto out_err;
+ }
+ }
mmc_set_timing(host, MMC_TIMING_MMC_DDR52);
+ /* Reduce frequency to HS */
+ max_dtr = card->ext_csd.hs_max_dtr;
+ mmc_set_clock(host, max_dtr);
+
err = mmc_switch_status(card);
if (err)
goto out_err;
--
1.8.1.1.dirty
next reply other threads:[~2019-02-13 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:06 Chaotian Jing [this message]
2019-02-13 12:08 ` [PATCH v1] mmc: mmc: Fix HS setting in mmc_hs400_to_hs200() Ulf Hansson
2019-02-14 2:14 ` Chaotian Jing
2019-02-14 8:14 ` Ulf Hansson
2019-02-14 8:40 ` Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550048812-29068-1-git-send-email-chaotian.jing@mediatek.com \
--to=chaotian.jing@mediatek.com \
--cc=adrian.hunter@intel.com \
--cc=harish_kandiga@mentor.com \
--cc=hongjiefang@asrmicro.com \
--cc=horms+renesas@verge.net.au \
--cc=kyle.roeschley@ni.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=shawn.lin@rock-chips.com \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox