From: Sean Wang <sean.wang@mediatek.com>
To: marcel@holtmann.org
Cc: johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: mediatek: Fixed incorrect type in assignment
Date: Tue, 19 Mar 2019 02:09:53 +0800 [thread overview]
Message-ID: <1552932593.24944.14.camel@mtkswgap22> (raw)
In-Reply-To: <64582ec6b953c055bc3cf18e7bba18d578f03b0a.1551744635.git.sean.wang@mediatek.com>
this is just a gentle ping
On Tue, 2019-03-05 at 08:14 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Fixed warning: incorrect type in assignment reported by kbuild test robot.
> The detailed warning is shown as below.
>
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> All warnings (new ones prefixed by >>):
>
> btmtkuart.c:671:18: sparse: warning: incorrect type in assignment
> (different base types)
> btmtkuart.c:671:18: sparse: expected unsigned int [usertype] baudrate
> btmtkuart.c:671:18: sparse: got restricted __le32 [usertype]
>
> sparse warnings: (new ones prefixed by >>)
> btmtkuart.c:671:18: sparse: warning: incorrect type in assignment
> (different base types)
> btmtkuart.c:671:18: sparse: expected unsigned int [usertype] baudrate
> btmtkuart.c:671:18: sparse: got restricted __le32 [usertype]
>
> vim +671 drivers/bluetooth/btmtkuart.c
>
> 659
> 660 static int btmtkuart_change_baudrate(struct hci_dev *hdev)
> 661 {
> 662 struct btmtkuart_dev *bdev = hci_get_drvdata(hdev);
> 663 struct btmtk_hci_wmt_params wmt_params;
> 664 u32 baudrate;
> 665 u8 param;
> 666 int err;
> 667
> 668 /* Indicate the device to enter the probe state the host is
> 669 * ready to change a new baudrate.
> 670 */
> > 671 baudrate = cpu_to_le32(bdev->desired_speed);
> 672 wmt_params.op = MTK_WMT_HIF;
>
> Fixes: 22eaf6c9946a ("Bluetooth: mediatek: add support for MediaTek MT7663U and MT7668U UART devices")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/bluetooth/btmtkuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c
> index b0b680dd69f4..f5dbeec8e274 100644
> --- a/drivers/bluetooth/btmtkuart.c
> +++ b/drivers/bluetooth/btmtkuart.c
> @@ -661,7 +661,7 @@ static int btmtkuart_change_baudrate(struct hci_dev *hdev)
> {
> struct btmtkuart_dev *bdev = hci_get_drvdata(hdev);
> struct btmtk_hci_wmt_params wmt_params;
> - u32 baudrate;
> + __le32 baudrate;
> u8 param;
> int err;
>
next prev parent reply other threads:[~2019-03-18 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 0:14 [PATCH] Bluetooth: mediatek: Fixed incorrect type in assignment sean.wang
2019-03-18 18:09 ` Sean Wang [this message]
2019-03-19 6:58 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552932593.24944.14.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox