Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze()

Chang-An Chen
2019-03-29T02:30:09Z

On Mon, 2019-03-25 at 21:54 +0800, Thomas Gleixner wrote:
> On Mon, 25 Mar 2019, Chang-An Chen wrote:
> > --- a/include/linux/sched_clock.h
> > +++ b/include/linux/sched_clock.h
> > @@ -13,6 +13,10 @@
> >
> > extern void sched_clock_register(u64 (*read)(void), int bits,
> > unsigned long rate);
> > +
> > +extern int sched_clock_suspend(void);
> > +
> > +extern void sched_clock_resume(void);
> > #else
> > static inline void generic_sched_clock_init(void) { }
> >
> > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits,
> > unsigned long rate)
> > {
> > }
> > +
> > +static int sched_clock_suspend(void) { }
>
> static inline ...
>
> > +
> > +static void sched_clock_resume(void) { }
>
> Ditto
>
> > #endif
>
> Please do not expose this in the global header. All of this is local to
> kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient.
Thanks so much for review and the suggestion, I'll fix it in next
version.

Thanks,
Chang-An
>
> Thanks,
>
> tglx
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek