Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze()

Thomas Gleixner
2019-03-25T13:54:05Z

On Mon, 25 Mar 2019, Chang-An Chen wrote:
> --- a/include/linux/sched_clock.h
> +++ b/include/linux/sched_clock.h
> @@ -13,6 +13,10 @@
>
> extern void sched_clock_register(u64 (*read)(void), int bits,
> unsigned long rate);
> +
> +extern int sched_clock_suspend(void);
> +
> +extern void sched_clock_resume(void);
> #else
> static inline void generic_sched_clock_init(void) { }
>
> @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits,
> unsigned long rate)
> {
> }
> +
> +static int sched_clock_suspend(void) { }

static inline ...

> +
> +static void sched_clock_resume(void) { }

Ditto

> #endif

Please do not expose this in the global header. All of this is local to
kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient.

Thanks,

tglx