RE: [PATCH 1/2] net-next: stmmac: add support for hash table size 128/256 in dwmac4

Jose Abreu
2019-04-29T09:00:53Z

From: Biao Huang <biao.huang@mediatek.com>
Date: Mon, Apr 29, 2019 at 07:35:23

> +#define GMAC_HASH_TAB(x) (0x10 + x * 4)

You need to guard x here with parenthesis.

> void __iomem *ioaddr = (void __iomem *)dev->base_addr;
> - unsigned int value = 0;
> + unsigned int value;
> + int i;
> + int numhashregs = (hw->multicast_filter_bins >> 5);
> + int mcbitslog2 = hw->mcast_bits_log2;

Reverse Christmas tree order here please.

Thanks,
Jose Miguel Abreu