From mboxrd@z Thu Jan 1 00:00:00 1970 From: xiaolei li Subject: Re: [PATCH 4/5] mtd: rawnand: mtk: Fix wrongly assigned oob buffer pointer issue Date: Mon, 29 Apr 2019 17:52:15 +0800 Message-ID: <1556531535.26455.44.camel@mhfsdcap03> References: <20190429063834.45967-1-xiaolei.li@mediatek.com> <20190429063834.45967-5-xiaolei.li@mediatek.com> <20190429111425.0c91c2f3@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190429111425.0c91c2f3@xps13> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Miquel Raynal Cc: richard-/L3Ra7n9ekc@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org SGkgTWlxdWVsLAoKT24gTW9uLCAyMDE5LTA0LTI5IGF0IDExOjE0ICswMjAwLCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+IEhpIFhpYW9sZWksCj4gCj4gWGlhb2xlaSBMaSA8eGlhb2xlaS5saUBtZWRp YXRlay5jb20+IHdyb3RlIG9uIE1vbiwgMjkgQXByIDIwMTkgMTQ6Mzg6MzMKPiArMDgwMDoKPiAK PiA+IE9uZSBtYWluIGdvYWwgb2YgdGhlIGZ1bmN0aW9uIG10a19uZmNfdXBkYXRlX2VjY19zdGF0 cyBpcyB0byBjaGVjawo+ID4gd2hldGhlciBzZWN0b3JzIGFyZSBhbGwgZW1wdHkuIElmIHRoZXkg YXJlIGVtcHR5LCBzZXQgdGhlc2Ugc2VjdG9ycydzCj4gPiBkYXRhIGJ1ZmZlciBhbmQgb29iIGJ1 ZmZlciBhcyAweGZmLgo+ID4gCj4gPiBCdXQgbm93LCB0aGUgc2VjdG9yIG9vYiBidWZmZXIgcG9p bnRlciBpcyB3cm9uZ2x5IGFzc2lnbmVkLiBXZSBhbHdheXMKPiA+IGRvIG1lbXNldCBmcm9tIHNl Y3RvciAwLgo+ID4gCj4gPiBUbyBmaXggdGhpcyBpc3N1ZSwgcGFzcyBzdGFydCBzZWNvdHIgbnVt YmVyIHRvIG1ha2Ugb29iIGJ1ZmZlciBwb2ludGVyCj4gCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzZWN0b3IKVGhhbmtzLiBXaWxsIGNoYW5nZSB0aGlzIHR5cG8uCgo+IAo+ID4g YmUgcHJvcGVybHkgYXNzaWduZWQuCj4gCj4gUGxlYXNlIHVzZSB1cHBlciBjYXNlIGZvciBwbGFp biBFbmdsaXNoIGFjcm9ueW1zOiBOQU5ELCBFQ0MsIE9PQiwgZXRjLgpPSy4KCj4gCj4gPiAKPiA+ IEZpeGVzOiA5M2RiNDQ2YTQyNGMgKCJtdGQ6IG5hbmQ6IG1vdmUgcmF3IE5BTkQgcmVsYXRlZCBj b2RlIHRvIHRoZSByYXcvIHN1YmRpciIpCj4gCj4gU2FtZSBjb21tZW50IGFzIGJlZm9yZSwgd3Jv bmcgY29tbWl0IHBvaW50ZWQgaW4gdGhlIEZpeGVzIHRhZy4KPiAKPiA+IFNpZ25lZC1vZmYtYnk6 IFhpYW9sZWkgTGkgPHhpYW9sZWkubGlAbWVkaWF0ZWsuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVy cy9tdGQvbmFuZC9yYXcvbXRrX25hbmQuYyB8IDIxICsrKysrKysrKystLS0tLS0tLS0tLQo+ID4g IDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMgYi9kcml2ZXJz L210ZC9uYW5kL3Jhdy9tdGtfbmFuZC5jCj4gPiBpbmRleCA3YTVlOGM5Y2Y2MWIuLmNmNWU1MGU3 MDRhZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMKPiA+ ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMKPiA+IEBAIC04NzMsMTkgKzg3 MywyMSBAQCBzdGF0aWMgaW50IG10a19uZmNfd3JpdGVfb29iX3N0ZChzdHJ1Y3QgbmFuZF9jaGlw ICpjaGlwLCBpbnQgcGFnZSkKPiA+ICAJcmV0dXJuIG10a19uZmNfd3JpdGVfcGFnZV9yYXcoY2hp cCwgTlVMTCwgMSwgcGFnZSk7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQgbXRrX25mY191 cGRhdGVfZWNjX3N0YXRzKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCB1OCAqYnVmLCB1MzIgc2VjdG9y cykKPiA+ICtzdGF0aWMgaW50IG10a19uZmNfdXBkYXRlX2VjY19zdGF0cyhzdHJ1Y3QgbXRkX2lu Zm8gKm10ZCwgdTggKmJ1ZiwgdTMyIHN0YXJ0LAo+ID4gKwkJCQkgICAgdTMyIHNlY3RvcnMpCj4g PiAgewo+ID4gIAlzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwID0gbXRkX3RvX25hbmQobXRkKTsKPiA+ ICAJc3RydWN0IG10a19uZmMgKm5mYyA9IG5hbmRfZ2V0X2NvbnRyb2xsZXJfZGF0YShjaGlwKTsK PiA+ICAJc3RydWN0IG10a19uZmNfbmFuZF9jaGlwICptdGtfbmFuZCA9IHRvX210a19uYW5kKGNo aXApOwo+ID4gIAlzdHJ1Y3QgbXRrX2VjY19zdGF0cyBzdGF0czsKPiA+ICsJdTMyIHJlZ19zaXpl ID0gbXRrX25hbmQtPmZkbS5yZWdfc2l6ZTsKPiA+ICAJaW50IHJjLCBpOwo+ID4gIAo+ID4gIAly YyA9IG5maV9yZWFkbChuZmMsIE5GSV9TVEEpICYgU1RBX0VNUF9QQUdFOwo+ID4gIAlpZiAocmMp IHsKPiA+ICAJCW1lbXNldChidWYsIDB4ZmYsIHNlY3RvcnMgKiBjaGlwLT5lY2Muc2l6ZSk7Cj4g PiAgCQlmb3IgKGkgPSAwOyBpIDwgc2VjdG9yczsgaSsrKQo+ID4gLQkJCW1lbXNldChvb2JfcHRy KGNoaXAsIGkpLCAweGZmLCBtdGtfbmFuZC0+ZmRtLnJlZ19zaXplKTsKPiA+ICsJCQltZW1zZXQo b29iX3B0cihjaGlwLCBzdGFydCArIGkpLCAweGZmLCByZWdfc2l6ZSk7Cj4gPiAgCQlyZXR1cm4g MDsKPiA+ICAJfQo+ID4gIAo+ID4gQEAgLTkwNSw3ICs5MDcsNyBAQCBzdGF0aWMgaW50IG10a19u ZmNfcmVhZF9zdWJwYWdlKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBzdHJ1Y3QgbmFuZF9jaGlwICpj aGlwLAo+ID4gIAl1MzIgc3BhcmUgPSBtdGtfbmFuZC0+c3BhcmVfcGVyX3NlY3RvcjsKPiA+ICAJ dTMyIGNvbHVtbiwgc2VjdG9ycywgc3RhcnQsIGVuZCwgcmVnOwo+ID4gIAlkbWFfYWRkcl90IGFk ZHI7Cj4gPiAtCWludCBiaXRmbGlwczsKPiA+ICsJaW50IGJpdGZsaXBzID0gMDsKPiA+ICAJc2l6 ZV90IGxlbjsKPiA+ICAJdTggKmJ1ZjsKPiA+ICAJaW50IHJjOwo+ID4gQEAgLTk3MiwxNCArOTc0 LDExIEBAIHN0YXRpYyBpbnQgbXRrX25mY19yZWFkX3N1YnBhZ2Uoc3RydWN0IG10ZF9pbmZvICpt dGQsIHN0cnVjdCBuYW5kX2NoaXAgKmNoaXAsCj4gPiAgCWlmIChyYyA8IDApIHsKPiA+ICAJCWRl dl9lcnIobmZjLT5kZXYsICJzdWJwYWdlIGRvbmUgdGltZW91dFxuIik7Cj4gPiAgCQliaXRmbGlw cyA9IC1FSU87Cj4gPiAtCX0gZWxzZSB7Cj4gPiAtCQliaXRmbGlwcyA9IDA7Cj4gPiAtCQlpZiAo IXJhdykgewo+ID4gLQkJCXJjID0gbXRrX2VjY193YWl0X2RvbmUobmZjLT5lY2MsIEVDQ19ERUNP REUpOwo+ID4gLQkJCWJpdGZsaXBzID0gcmMgPCAwID8gLUVUSU1FRE9VVCA6Cj4gPiAtCQkJCW10 a19uZmNfdXBkYXRlX2VjY19zdGF0cyhtdGQsIGJ1Ziwgc2VjdG9ycyk7Cj4gPiAtCQkJbXRrX25m Y19yZWFkX2ZkbShjaGlwLCBzdGFydCwgc2VjdG9ycyk7Cj4gPiAtCQl9Cj4gPiArCX0gZWxzZSBp ZiAoIXJhdykgewo+ID4gKwkJcmMgPSBtdGtfZWNjX3dhaXRfZG9uZShuZmMtPmVjYywgRUNDX0RF Q09ERSk7Cj4gPiArCQliaXRmbGlwcyA9IHJjIDwgMCA/IC1FVElNRURPVVQgOgo+ID4gKwkJCW10 a19uZmNfdXBkYXRlX2VjY19zdGF0cyhtdGQsIGJ1Ziwgc3RhcnQsIHNlY3RvcnMpOwo+ID4gKwkJ bXRrX25mY19yZWFkX2ZkbShjaGlwLCBzdGFydCwgc2VjdG9ycyk7Cj4gPiAgCX0KPiA+ICAKPiA+ ICAJZG1hX3VubWFwX3NpbmdsZShuZmMtPmRldiwgYWRkciwgbGVuLCBETUFfRlJPTV9ERVZJQ0Up Owo+IAo+IFdpdGggdGhpcyBhZGRyZXNzZWQ6Cj4gCj4gUmV2aWV3ZWQtYnk6IE1pcXVlbCBSYXlu YWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gCj4gCj4gVGhhbmtzLAo+IE1pcXXDqGwK CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt bWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRl awo=