From mboxrd@z Thu Jan 1 00:00:00 1970 From: biao huang Subject: RE: [PATCH 1/4] net: stmmac: update rx tail pointer register to fix rx dma hang issue. Date: Tue, 30 Apr 2019 16:56:00 +0800 Message-ID: <1556614560.24897.31.camel@mhfsdcap03> References: <1556518556-32464-1-git-send-email-biao.huang@mediatek.com> <1556518556-32464-2-git-send-email-biao.huang@mediatek.com> <78EB27739596EE489E55E81C33FEC33A0B46DDF0@DE02WEMBXB.internal.synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B46DDF0@DE02WEMBXB.internal.synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Jose Abreu Cc: "davem@davemloft.net" , Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Matthias Brugger , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "yt.shen@mediatek.com" , "jianguo.zhang@mediatek.com" List-Id: linux-mediatek@lists.infradead.org On Mon, 2019-04-29 at 08:51 +0000, Jose Abreu wrote: > From: Biao Huang > Date: Mon, Apr 29, 2019 at 07:15:53 > > > Currently we will not update the receive descriptor tail pointer in > > stmmac_rx_refill. Rx dma will think no available descriptors and stop > > once received packets exceed DMA_RX_SIZE, so that the rx only test will fail. > > > > Update the receive tail pointer in stmmac_rx_refill to add more descriptors > > to the rx channel, so packets can be received continually > > > > Signed-off-by: Biao Huang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 97c5e1a..818ad88 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -3336,6 +3336,9 @@ static inline void stmmac_rx_refill(struct stmmac_priv *priv, u32 queue) > > entry = STMMAC_GET_ENTRY(entry, DMA_RX_SIZE); > > } > > rx_q->dirty_rx = entry; > > + stmmac_set_rx_tail_ptr(priv, priv->ioaddr, > > + rx_q->dma_rx_phy + (entry * sizeof(struct dma_desc)), > > I think you can just use the "rx_q->rx_tail_addr" here. It'll always > trigger a poll demand for the channel. Yes, will use rx_q->rx_tail_addr here. > > Thanks, > Jose Miguel Abreu