From mboxrd@z Thu Jan 1 00:00:00 1970 From: biao huang Subject: RE: [PATCH 1/2] net-next: stmmac: add support for hash table size 128/256 in dwmac4 Date: Tue, 30 Apr 2019 16:59:23 +0800 Message-ID: <1556614763.24897.34.camel@mhfsdcap03> References: <1556519724-1576-1-git-send-email-biao.huang@mediatek.com> <1556519724-1576-2-git-send-email-biao.huang@mediatek.com> <78EB27739596EE489E55E81C33FEC33A0B46DE20@DE02WEMBXB.internal.synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B46DE20@DE02WEMBXB.internal.synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Jose Abreu Cc: "davem@davemloft.net" , Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Matthias Brugger , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "yt.shen@mediatek.com" , "jianguo.zhang@mediatek.com" List-Id: linux-mediatek@lists.infradead.org On Mon, 2019-04-29 at 09:00 +0000, Jose Abreu wrote: > From: Biao Huang > Date: Mon, Apr 29, 2019 at 07:35:23 > > > +#define GMAC_HASH_TAB(x) (0x10 + x * 4) > > You need to guard x here with parenthesis. > > > void __iomem *ioaddr = (void __iomem *)dev->base_addr; > > - unsigned int value = 0; > > + unsigned int value; > > + int i; > > + int numhashregs = (hw->multicast_filter_bins >> 5); > > + int mcbitslog2 = hw->mcast_bits_log2; > > Reverse Christmas tree order here please. OK. > > Thanks, > Jose Miguel Abreu