Re: [PATCH v5 04/12] dt-binding: gce: add binding for gce event property

CK Hu
2019-05-08T05:10:47Z

Hi, Bibby:

On Tue, 2019-05-07 at 16:13 +0800, Bibby Hsieh wrote:
> Client hardware would send event to GCE hardware,
> mediatek,gce-event-names and mediatek,gce-events
> can be used to present the event.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index 8fd9479bc9f6..76491f194c56 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -35,6 +35,9 @@ Required properties for a client device:
> Optional propertier for a client device:
> - mediatek,gce-client-reg: u32, specify the sub-system id which is corresponding
> to the register address.
> +- mediatek,gce-event-names: the event name can be defined by user.

gce-event is like an interrupt from client hardware to GCE hardware, we
do not give a name to an interrupt, so do we need to give a name for
gce-event?

Regards,
CK

> +- mediatek,gce-events: u32, the event number defined in
> + 'dt-bindings/gce/mt8173-gce.h' or 'dt-binding/gce/mt8183-gce.h'.
>
> Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h'
> or 'dt-binding/gce/mt8183-gce.h'. Such as sub-system ids, thread priority, event ids.
> @@ -57,8 +60,10 @@ Example for a client device:
> compatible = "mediatek,mt8173-mmsys";
> mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>,
> <&gce 1 CMDQ_THR_PRIO_LOWEST 1>;
> - mutex-event-eof = <CMDQ_EVENT_MUTEX0_STREAM_EOF
> - CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> + mediatek,gce-event-names = "rdma0_sof",
> + "rsz0_sof";
> + mediatek,gce-events = <CMDQ_EVENT_MDP_RDMA0_SOF>,
> + <CMDQ_EVENT_MDP_RSZ0_SOF>;
> mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>,
> <&gce SUBSYS_1401XXXX 0x2000 0x100>;
> ...