Re: [PATCH 2/8] arm64: dts: mt8183: add/update dynamic power coefficients

Hsin-Yi Wang
2019-05-03T07:16:29Z

On Thu, May 2, 2019 at 10:43 AM michael.kao <michael.kao@mediatek.com> wrote:
>
> Add dynamic power coefficients for all cores and update those of
> CPU0 and CPU4.
>
> Signed-off-by: Michael.Kao <michael.kao@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index b92116f..5668fb8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -58,6 +58,8 @@
> compatible = "arm,cortex-a53";
> reg = <0x000>;
> enable-method = "psci";
> + dynamic-power-coefficient = <84>;
> + #cooling-cells = <2>;
Should this line be in [3/8] arm64: dts: mt8183: Add #cooling-cells to
CPU nodes?

> };
>
> cpu1: cpu@1 {
> @@ -65,6 +67,8 @@
> compatible = "arm,cortex-a53";
> reg = <0x001>;
> enable-method = "psci";
> + dynamic-power-coefficient = <84>;
> + #cooling-cells = <2>;
> };
>
> cpu2: cpu@2 {
> @@ -72,6 +76,8 @@
> compatible = "arm,cortex-a53";
> reg = <0x002>;
> enable-method = "psci";
> + dynamic-power-coefficient = <84>;
> + #cooling-cells = <2>;
> };
>
> cpu3: cpu@3 {
> @@ -79,6 +85,8 @@
> compatible = "arm,cortex-a53";
> reg = <0x003>;
> enable-method = "psci";
> + dynamic-power-coefficient = <84>;
> + #cooling-cells = <2>;
> };
>
> cpu4: cpu@100 {
> @@ -86,6 +94,8 @@
> compatible = "arm,cortex-a73";
> reg = <0x100>;
> enable-method = "psci";
> + dynamic-power-coefficient = <211>;
> + #cooling-cells = <2>;
> };
>
> cpu5: cpu@101 {
> @@ -93,6 +103,8 @@
> compatible = "arm,cortex-a73";
> reg = <0x101>;
> enable-method = "psci";
> + dynamic-power-coefficient = <211>;
> + #cooling-cells = <2>;
> };
>
> cpu6: cpu@102 {
> @@ -100,6 +112,8 @@
> compatible = "arm,cortex-a73";
> reg = <0x102>;
> enable-method = "psci";
> + dynamic-power-coefficient = <211>;
> + #cooling-cells = <2>;
> };
>
> cpu7: cpu@103 {
> @@ -107,6 +121,8 @@
> compatible = "arm,cortex-a73";
> reg = <0x103>;
> enable-method = "psci";
> + dynamic-power-coefficient = <211>;
> + #cooling-cells = <2>;
> };
> };
>