Re: [PATCH 6/8] thermal: mediatek: mt8183: fix bank number settings

Hsin-Yi Wang
2019-05-07T08:58:40Z

On Thu, May 2, 2019 at 10:43 AM michael.kao <michael.kao@mediatek.com> wrote:
>
> From: Michael Kao <michael.kao@mediatek.com>
>
> MT8183_NUM_ZONES should be set to 1
> because MT8183 doesn't have multiple banks.
>
> Fixes: a4ffe6b52d27 ("thermal: mediatek: add support for MT8183")
> Signed-off-by: Michael Kao <Michael.Kao@mediatek.com>
> ---
> drivers/thermal/mtk_thermal.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 5c07a61..cb41e46 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -216,6 +216,9 @@ enum {
> /* The total number of temperature sensors in the MT8183 */
> #define MT8183_NUM_SENSORS 6
>
> +/* The number of banks in the MT8183 */
> +#define MT8183_NUM_ZONES 1
> +
> /* The number of sensing points per bank */
> #define MT8183_NUM_SENSORS_PER_ZONE 6
>
> @@ -503,7 +506,7 @@ struct mtk_thermal {
>
> static const struct mtk_thermal_data mt8183_thermal_data = {
> .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL,
> - .num_banks = MT8183_NUM_SENSORS_PER_ZONE,
> + .num_banks = MT8183_NUM_ZONES,
> .num_sensors = MT8183_NUM_SENSORS,
> .vts_index = mt8183_vts_index,
> .cali_val = MT8183_CALIBRATION,

Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>