From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanley Chu Subject: RE: [PATCH v3 2/3] scsi: ufs: Add error-handling of Auto-Hibernate Date: Mon, 20 May 2019 22:05:29 +0800 Message-ID: <1558361129.660.8.camel@mtkswgap22> References: <1558341138-18043-1-git-send-email-stanley.chu@mediatek.com> <1558341138-18043-3-git-send-email-stanley.chu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Avri Altman Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "marc.w.gonzalez@free.fr" , "andy.teng@mediatek.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "evgreen@chromium.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "pedrom.sousa@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" List-Id: linux-mediatek@lists.infradead.org Hi Avri, On Mon, 2019-05-20 at 09:51 +0000, Avri Altman wrote: > Aside from some nits - see below, looks fine. > > Thanks, > Avri > > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > > index ecfa898b9ccc..994d73d03207 100644 > > --- a/drivers/scsi/ufs/ufshcd.h > > +++ b/drivers/scsi/ufs/ufshcd.h > > @@ -740,6 +740,11 @@ return true; > > #endif > > } > > > > +static inline bool ufshcd_is_auto_hibern8_supported(struct ufs_hba *hba) > > +{ > > + return (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT); > > +} > Maybe use it elsewhere in the driver, preferable in a preparatory patch, > Instead of patch #3. > OK. I will modify original patch #3 to a preparation patch which just re-factors ufshcd_is_auto_hibern8_supported(), and change its order to #2. > > > > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h > > index 6fa889de5ee5..4bcb205f2077 100644 > > --- a/drivers/scsi/ufs/ufshci.h > > +++ b/drivers/scsi/ufs/ufshci.h > > @@ -148,6 +148,9 @@ enum { > > UIC_HIBERNATE_EXIT |\ > > UIC_POWER_MODE) > > > > +#define UFSHCD_UIC_AH8_ERROR_MASK (UIC_HIBERNATE_ENTER |\ > > + UIC_HIBERNATE_EXIT) > So maybe update UFSHCD_UIC_PWR_MASK above OK. WIll make these definitions more elegant. > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek Thanks, Stanley