From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qii Wang Subject: Re: [PATCH v2] i2c: mediatek: disable zero-length transfers for mt8183 Date: Sat, 24 Aug 2019 11:23:20 +0800 Message-ID: <1566617000.19935.7.camel@mhfsdcap03> References: <20190822094516.55130-1-hsinyi@chromium.org> <1566547772.19935.2.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hsin-Yi Wang Cc: Nicolas Boichat , Alexandru M Stan , Wolfram Sang , Jun Gao , lkml , linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , Yingjoe Chen , Thomas Gleixner , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: linux-mediatek@lists.infradead.org On Fri, 2019-08-23 at 16:13 +0800, Hsin-Yi Wang wrote: > On Fri, Aug 23, 2019 at 4:09 PM Qii Wang wrote: > > > > > > > static u32 mtk_i2c_functionality(struct i2c_adapter *adap) > > > { > > > - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > + if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > > > + return I2C_FUNC_I2C | > > > + (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > > + else > > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > > It can be removed? > See previous discussion: https://patchwork.kernel.org/patch/10814391/#22484435 > but not all SoC's quirks has I2C_AQ_NO_ZERO_LEN. ok, it looks good for me, thanks. Reviewed-by: Qii Wang