Re: [PATCH V3 08/10] dt-bindings: interconnect: add MT8183 interconnect dt-bindings

Henry Chen
2019-09-03T12:36:50Z

On Mon, 2019-09-02 at 14:38 +0100, Rob Herring wrote:
Hi Rob,
> On Wed, Aug 28, 2019 at 08:28:46PM +0800, Henry Chen wrote:
> > Add interconnect provider dt-bindings for MT8183.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > .../devicetree/bindings/soc/mediatek/dvfsrc.txt | 9 +++++++++
> > include/dt-bindings/interconnect/mtk,mt8183-emi.h | 18 ++++++++++++++++++
> > 2 files changed, 27 insertions(+)
> > create mode 100644 include/dt-bindings/interconnect/mtk,mt8183-emi.h
> >
> > diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > index 7f43499..da98ec9 100644
> > --- a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > +++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > @@ -12,6 +12,11 @@ Required Properties:
> > - clock-names: Must include the following entries:
> > "dvfsrc": DVFSRC module clock
> > - clocks: Must contain an entry for each entry in clock-names.
> > +- #interconnect-cells : should contain 1
> > +- interconnect : interconnect providers support dram bandwidth requirements.
> > + The provider is able to communicate with the DVFSRC and send the dram
> > + bandwidth to it. shall contain only one of the following:
> > + "mediatek,mt8183-emi"
> >
> > Example:
> >
> > @@ -20,4 +25,8 @@ Example:
> > reg = <0 0x10012000 0 0x1000>;
> > clocks = <&infracfg CLK_INFRA_DVFSRC>;
> > clock-names = "dvfsrc";
> > + ddr_emi: interconnect {
>
> The EMI is a sub-module in the DVFSRC? This is the DDR controller or
> something else?
Yes, EMI is a sub-module in the DVFSRC, the EMI through interconnect
framework to collect DRAM bandwidth from other device drivers and will
send the bandwidth result to DVFSRC driver.
>
>
> > + compatible = "mediatek,mt8183-emi";
> > + #interconnect-cells = <1>;
> > + };
> > };
>