Re: [PATCH v3 1/3] scsi: core: allow auto suspend override by low-level driver

Bart Van Assche
2019-09-16T15:16:16Z

On 9/15/19 11:47 PM, Stanley Chu wrote:
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index 202f4d6a4342..495e30adb53f 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -199,7 +199,7 @@ struct scsi_device {
> unsigned broken_fua:1; /* Don't set FUA bit */
> unsigned lun_in_cdb:1; /* Store LUN bits in CDB[1] */
> unsigned unmap_limit_for_ws:1; /* Use the UNMAP limit for WRITE SAME */
> -
> + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> atomic_t disk_events_disable_depth; /* disable depth for disk events */
The "_on" part in the variable name "rpm_autosuspend_on" is probably
redundant and the comment could have been more elaborate. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>